Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

fix route parsing#73

Merged
NikhilShahi merged 2 commits into
mainhyperbrowserai/python-sdk:mainfrom
regional-path-runtime-supporthyperbrowserai/python-sdk:regional-path-runtime-supportCopy head branch name to clipboard
Apr 14, 2026
Merged

fix route parsing#73
NikhilShahi merged 2 commits into
mainhyperbrowserai/python-sdk:mainfrom
regional-path-runtime-supporthyperbrowserai/python-sdk:regional-path-runtime-supportCopy head branch name to clipboard

Conversation

@Dingway98
Copy link
Copy Markdown
Contributor

@Dingway98 Dingway98 commented Apr 14, 2026


Open with Devin

Note

Medium Risk
Adjusts how runtime API and exposed-port URLs are constructed, which can affect connectivity for existing sandbox sessions if path/host parsing is wrong. Changes are covered by updated unit and e2e assertions but still touch core routing logic.

Overview
Fixes sandbox runtime URL construction to correctly handle regional runtime baseUrls that already include /sandbox/{sessionId} and to avoid double-/missing-/sandbox prefixes when joining relative paths.

Exposed port URLs now incorporate the sandbox session id into the hostname (e.g. https://3000-sbx_123.runtime.example.com/) by extracting the id from runtime.base_url (or runtime.host fallback) and always emitting a root-path exposed URL.

Updates wire-contract/e2e tests to assert the new URL shapes and adds targeted tests for the new parsing helpers; bumps version to 0.90.3.

Reviewed by Cursor Bugbot for commit 2cc8e0e. Bugbot is set up for automated code reviews on this repo. Configure here.

Copy link
Copy Markdown

@devin-ai-integration devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 5 additional findings.

Open in Devin Review

cursor[bot]

This comment was marked as resolved.

@NikhilShahi NikhilShahi merged commit b99f53c into main Apr 14, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.