Don't use cElementTree on Python 3#502
Don't use cElementTree on Python 3#502gsnedders merged 1 commit intohtml5lib:masterhtml5lib/html5lib-python:masterfrom gsnedders:conditional_etreegsnedders/html5lib-python:conditional_etreeCopy head branch name to clipboard
Conversation
Codecov Report
@@ Coverage Diff @@
## master #502 +/- ##
=======================================
Coverage 91.06% 91.06%
=======================================
Files 50 50
Lines 7036 7038 +2
Branches 1340 1341 +1
=======================================
+ Hits 6407 6409 +2
Misses 475 475
Partials 154 154
Continue to review full report at Codecov.
|
jgraham
left a comment
There was a problem hiding this comment.
r+ but I agree with the preference for if not PY2 in this case, although I'm obviously hoping Python 4 isn't a real thing since it will just cause more needless breakage.
It's been deprecated and will be removed in 3.9 or 3.10. 3.9.0b1 doesn't have cElementTree. I'd like to bring it back with a deprecation warning to drop in 3.10. See: python/cpython#19921 Signed-off-by: Christian Heimes <christian@python.org> Signed-off-by: Sam Sneddon <me@gsnedders.com>
3d62987 to
e4ff95f
Compare
Note that this has been discussed upstream at six on a number of occasions: see https://bitbucket.org/gutworth/six/issues/22/variable-sixpy3-is-time-bomb and benjaminp/six#297, as well as the python-dev thread at https://mail.python.org/archives/list/python-dev@python.org/thread/M5N3PZP4IUMKRZJKKJQA4IXK5VDX5MOP/ about 3.10 v. 4. |
|
I'm landing this as-is because if that's what a CPython core developer is doing that's good enough for me 🤷 |
This just directly imports the first commit from pypa/pip#8278. Fixes #494. This doesn't fill me with joy, but I guess sometimes we do the perhaps silly thing for pip.
(@tiran this is just your commit, let me know if you have any objection to it landing here)