Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Ensure opentherm_gw boiler and thermostat manufacturers are strings#173162

Open
mvn23 wants to merge 2 commits into
home-assistant:devhome-assistant/core:devfrom
mvn23:opentherm-fix-manufacturermvn23/home-assistant:opentherm-fix-manufacturerCopy head branch name to clipboard
Open

Ensure opentherm_gw boiler and thermostat manufacturers are strings#173162
mvn23 wants to merge 2 commits into
home-assistant:devhome-assistant/core:devfrom
mvn23:opentherm-fix-manufacturermvn23/home-assistant:opentherm-fix-manufacturerCopy head branch name to clipboard

Conversation

@mvn23
Copy link
Copy Markdown
Contributor

@mvn23 mvn23 commented Jun 6, 2026

Proposed change

Ensure the opentherm_gw boiler and thermostat device manufacturers are string values.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies a diff between library versions and ideally a link to the changelog/release notes is added to the PR description.

To help with the load of incoming pull requests:

Copilot AI review requested due to automatic review settings June 6, 2026 15:15
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

This PR wraps the manufacturer field values with str() when updating device registry entries for the boiler and thermostat devices in the OpenTherm Gateway integration.

Changes:

  • Wraps manufacturer values in str() for the boiler device registry update.
  • Wraps manufacturer values in str() for the thermostat device registry update.

Comment thread homeassistant/components/opentherm_gw/__init__.py Outdated
Comment thread homeassistant/components/opentherm_gw/__init__.py Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Log reports warning about almost deprecated value type in opentherm_gw

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.