Ensure opentherm_gw boiler and thermostat manufacturers are strings#173162
Open
mvn23 wants to merge 2 commits into
home-assistant:devhome-assistant/core:devfrom
mvn23:opentherm-fix-manufacturermvn23/home-assistant:opentherm-fix-manufacturerCopy head branch name to clipboard
Open
Ensure opentherm_gw boiler and thermostat manufacturers are strings#173162mvn23 wants to merge 2 commits intohome-assistant:devhome-assistant/core:devfrom mvn23:opentherm-fix-manufacturermvn23/home-assistant:opentherm-fix-manufacturerCopy head branch name to clipboard
mvn23 wants to merge 2 commits into
home-assistant:devhome-assistant/core:devfrom
mvn23:opentherm-fix-manufacturermvn23/home-assistant:opentherm-fix-manufacturerCopy head branch name to clipboard
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR wraps the manufacturer field values with str() when updating device registry entries for the boiler and thermostat devices in the OpenTherm Gateway integration.
Changes:
- Wraps
manufacturervalues instr()for the boiler device registry update. - Wraps
manufacturervalues instr()for the thermostat device registry update.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Ensure the opentherm_gw boiler and thermostat device manufacturers are string values.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: