fix(lgsm): stream SteamCMD progress without buffering#71
Open
IOHelpMe wants to merge 1 commit into
highcard-dev:masterhighcard-dev/scrolls:masterfrom
IOHelpMe:marvin/hig-24-line-buffer-lgsm-progressIOHelpMe/scrolls:marvin/hig-24-line-buffer-lgsm-progressCopy head branch name to clipboard
Open
fix(lgsm): stream SteamCMD progress without buffering#71IOHelpMe wants to merge 1 commit intohighcard-dev:masterhighcard-dev/scrolls:masterfrom IOHelpMe:marvin/hig-24-line-buffer-lgsm-progressIOHelpMe/scrolls:marvin/hig-24-line-buffer-lgsm-progressCopy head branch name to clipboard
IOHelpMe wants to merge 1 commit into
highcard-dev:masterhighcard-dev/scrolls:masterfrom
IOHelpMe:marvin/hig-24-line-buffer-lgsm-progressIOHelpMe/scrolls:marvin/hig-24-line-buffer-lgsm-progressCopy head branch name to clipboard
Conversation
Collaborator
|
Author
|
@MarcStdt Ready for review. SteamCMD already emitted frequent real progress, but |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
stdbuf -oLSnapshotProgressas the only progress source; no estimates or synthetic valuesWhy
SteamCMD emits real progress frequently, but
uniqbuffered the pipe output. That delayed valid samples and produced the observed long pauses and large jumps. Line buffering forwards each existing progress line immediately without adding a PTY or another progress mechanism.Verification
go test -count=1 ./..../scripts/validate_all_scrolls.shgit diff --checkRelated: highcard-dev/druid-cli#97 and highcard-dev/monorepo#318.