Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Add pythonConvention HL class (cls and self)#54

Closed
AloisMahdal wants to merge 1 commit into
hdima:masterhdima/python-syntax:masterfrom
AloisMahdal:conventionCopy head branch name to clipboard
Closed

Add pythonConvention HL class (cls and self)#54
AloisMahdal wants to merge 1 commit into
hdima:masterhdima/python-syntax:masterfrom
AloisMahdal:conventionCopy head branch name to clipboard

Conversation

@AloisMahdal

Copy link
Copy Markdown

These are especially useful in OOP as they help visually distinguish how
many parameters the function will be called with (in signature), or
actual state preservation from transient or return variables (in
function body).

These are especially useful in OOP as they help visually distinguish how
many parameters the function will be called with (in signature), or
actual state preservation from transient or return variables (in
function body).
@AloisMahdal

Copy link
Copy Markdown
Author

This has been hanging in my closet for a while, catching dust.

Similar to #48 except that this one takes also cls into account and uses separate highlight group.

jakar added a commit to jakar/vim-python-syntax that referenced this pull request Oct 7, 2016
@jakar

jakar commented Oct 7, 2016

Copy link
Copy Markdown

After reading some older issues and pull requests, it looks like @hdima is pretty opposed to highlighting self. So perhaps leave pythonConvention, but don't link it to Define?

jakar added a commit to jakar/vim-python-syntax that referenced this pull request Oct 7, 2016

@rmariano rmariano left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I appied the patch in my fork. Looks good, thanks

@AloisMahdal AloisMahdal closed this Jun 6, 2018
@AloisMahdal AloisMahdal deleted the convention branch June 6, 2018 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.