feat: implement entry ID lookup by filename for jurors#550
Open
ayushshukla1807 wants to merge 1 commit into
hatnote:masterhatnote/montage:masterfrom
ayushshukla1807:feat/entry-lookup-by-filenameayushshukla1807/montage:feat/entry-lookup-by-filenameCopy head branch name to clipboard
Open
feat: implement entry ID lookup by filename for jurors#550ayushshukla1807 wants to merge 1 commit intohatnote:masterhatnote/montage:masterfrom ayushshukla1807:feat/entry-lookup-by-filenameayushshukla1807/montage:feat/entry-lookup-by-filenameCopy head branch name to clipboard
ayushshukla1807 wants to merge 1 commit into
hatnote:masterhatnote/montage:masterfrom
ayushshukla1807:feat/entry-lookup-by-filenameayushshukla1807/montage:feat/entry-lookup-by-filenameCopy head branch name to clipboard
Conversation
ItsAbhinavM
requested changes
Jul 20, 2026
ItsAbhinavM
left a comment
Collaborator
There was a problem hiding this comment.
@ayushshukla1807 thank you for your contribution, the changes looks good but have some logical mistakes which can be fixed. The function get_entry_lookup doesn't route user_dao through JurorDAO due to which entry/user details outside the juror round can be returned and not-found filenames currently raises DoesNotExist than raising a standard {'status':'failure'} which shapes the rest of the function uses. Fixing these two would work in further steps on merging it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR clears a long-standing TODO in
juror_endpoints.pyby implementing a filename-based entry lookup for jurors.Changes:
get_entry_by_nametoUserDAOinrdb.pyto support global entry lookups.GET /juror/entry_lookupendpoint which accepts afilenameparameter.File:prefix, handling spaces/underscores) to ensure robust lookups.This is a highly useful utility for jurors who need to cross-reference specific files by name rather than internal database IDs.