Export data as .json#27
Open
wesinator wants to merge 2 commits into
Open
Export data as .json#27wesinator wants to merge 2 commits into
wesinator wants to merge 2 commits into
Conversation
KOLANICH
approved these changes
Aug 16, 2020
KOLANICH
reviewed
Aug 16, 2020
| f = document.createElement("iframe"); | ||
| f.id = id; | ||
| f.srcdoc = `<a download="noscript_data.txt" target="_blank">NoScript Export</a>`; | ||
| f.srcdoc = `<a download="noscript_data.json" target="_blank">NoScript Export</a>`; |
There was a problem hiding this comment.
BTW, I completely dislike when DOM nodes are created with the ways like innerHTML using hardcoded HTML. IMHO they should always be created using DOM API.
a578ed7 to
c7bf7f0
Compare
|
see also #512 |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use .json extension on export