Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

netty: use netty default SO_BACKLOG - #6956

#6956
Merged
creamsoup merged 1 commit into
grpc:mastergrpc/grpc-java:masterfrom
creamsoup:remove_netty_so_backlogcreamsoup/grpc-java:remove_netty_so_backlogCopy head branch name to clipboard
Apr 22, 2020
Merged

netty: use netty default SO_BACKLOG#6956
creamsoup merged 1 commit into
grpc:mastergrpc/grpc-java:masterfrom
creamsoup:remove_netty_so_backlogcreamsoup/grpc-java:remove_netty_so_backlogCopy head branch name to clipboard

Conversation

@creamsoup

Copy link
Copy Markdown
Contributor

as @ejona86 pointed out, we don't need to set SO_BACKLOG in netty. see #6947 (comment)

@creamsoup
creamsoup requested a review from ejona86 April 21, 2020 17:39

@asdf2014 asdf2014 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@creamsoup
creamsoup merged commit 0059c5a into grpc:master Apr 22, 2020
@creamsoup
creamsoup deleted the remove_netty_so_backlog branch April 22, 2020 16:10
dfawley pushed a commit to dfawley/grpc-java that referenced this pull request Jan 15, 2021
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jun 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.