Conversation
jmbtutor
left a comment
There was a problem hiding this comment.
Looks good. Just the one comment about casting vs bracket property access.
|
|
||
| withoutSorts(...sorts: Sort[]): Query { | ||
| this.request.sort = this.request.sort.filter((oldSort) => !sorts.find((sort) => sort.field === oldSort.field)); | ||
| this.request.sort = this.request.sort.filter((oldSort) => !sorts.find((sort) => |
There was a problem hiding this comment.
This feels inefficient because it's an O(n2) algorithm. We can bring it down to O(n) by going through sorts and adding each string representation of ids as keys to an ids object and each field as keys to a fields object, then going through this.request.sort and looking them up in the appropriate objects.
That said, sorts (and possibly this.request.sort) is probably going to be small enough (less than 5?) that we can probably get away with what we're already doing.
Codecov Report
@@ Coverage Diff @@
## develop #85 +/- ##
===========================================
+ Coverage 99.17% 99.17% +<.01%
===========================================
Files 3 3
Lines 241 243 +2
Branches 22 23 +1
===========================================
+ Hits 239 241 +2
Partials 2 2
Continue to review full report at Codecov.
|
No description provided.