proxy bridge#84
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #84 +/- ##
========================================
Coverage 99.17% 99.17%
========================================
Files 3 3
Lines 241 241
Branches 21 22 +1
========================================
Hits 239 239
Partials 2 2
Continue to review full report at Codecov.
|
effervescentia
suggested changes
May 22, 2018
| } | ||
| } | ||
|
|
||
| export class ProxyBridge extends AbstractBridge { |
Contributor
There was a problem hiding this comment.
rather than add a whole new class, I would simply make baseUrl an optional property of BridgeConfig
then in the constructor()s of BrowserBridge and CloudBridge you can just have
export interface BridgeConfig {
timeout?: number;
baseUrl?: string;
}
// in constructor()
this.baseUrl = config.baseUrl ||`${scheme}://${customerId}-cors.groupbycloud.com${port}/api/v1`;
// and
this.baseUrl = config.baseUrl || `https://${customerId}.groupbycloud.com:443/api/v1`;
Contributor
There was a problem hiding this comment.
or even proxyUrl so that you don't have to change your other PR much :P
effervescentia
approved these changes
May 22, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.