Use FEDERATION_NAME in management.html template#131
Open
vladimir-mencl-eresearch wants to merge 1 commit into
Open
Use FEDERATION_NAME in management.html template#131vladimir-mencl-eresearch wants to merge 1 commit into
vladimir-mencl-eresearch wants to merge 1 commit into
Conversation
We already have FEDERATION_NAME context parameter. Use it in more places on the /management page, instead of literal "AAI Federation". Adjust localisation file accordingly.
Collaborator
Author
|
@Razorfang @ghalse could I please ask you for a review? |
Razorfang
reviewed
Jul 24, 2026
| #: djnro/templates/front/management.html:14 | ||
| msgid "" | ||
| "Administrators can log in using either Social Networks or the AAI Federation:" | ||
| "Administrators can log in using either Social Networks or the %(FEDERATION_NAME)s:" |
Contributor
There was a problem hiding this comment.
Should there be an s at the end here? What if the value of FEDERATION_NAME doesn't suit well to this format?
Collaborator
Author
There was a problem hiding this comment.
The s indicates string format in this syntax (as opposed to d for numeric).
Contributor
There was a problem hiding this comment.
Ah, my bad. In that case everything seems fine to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We already have FEDERATION_NAME context parameter.
Use it in more places on the /management page, instead of literal "AAI Federation".
Adjust localisation file accordingly.