Add experimental support for directives on directive definitions by BoD · Pull Request #4521 · graphql/graphql-js

BoD · Jan 6, 2026

Allow directives on directive definitions, based on this spec PR which introduces this syntax:

directive @onDirective on DIRECTIVE_DEFINITION

directive @foo @onDirective on OBJECT

directive @baz @deprecated(reason: "...") on OBJECT

extend directive @quux @deprecated(reason: "...")

Disclaimer

First time on this codebase and am also not a JS/TS person, so obvious mistakes and/or missing pieces are very likely 😅 Any help and feedback to improve this PR are very welcome 🙏. The tests seem to pass but additional tests may be needed.

vercel · Jan 6, 2026

@BoD is attempting to deploy a commit to the The GraphQL Foundation Team on Vercel.

A member of the Team first needs to authorize it.

leebyron · Apr 2, 2026

Update includeDeprecated arg per @benjie 's comments, then we'll merge

BoD · Apr 3, 2026

Just made the change for includeDeprecated: Boolean! + added one test.

jerelmiller

Had a few suggestions, mostly around types, but otherwise looks good from my end!

You probably want to get a proper review from someone who knows the conventions in this codebase better than I do, but wanted to try and help move this along in some way!

benjie · Apr 7, 2026

I've not fully reviewed this PR, but the changes since Lee's review all look fine to me - thanks @BoD! 👍

…ied to a directive

Co-authored-by: Jerel Miller <jerelmiller@gmail.com>

yaacovCR · Apr 24, 2026

@BoD dropped in a few commits with fixes, possibly spec for some of them has to be correlated => have to check out ci failures a bit later….

## v16.14.0 (2026-05-03) #### New Feature 🚀 * [#4317](#4317) Allow configuration of the `ofType` introspection depth ([@Nols1000](https://github.com/Nols1000)) * [#4521](#4521) Add experimental support for directives on directive definitions ([@BoD](https://github.com/BoD)) #### Bug Fix 🐞 * [#4652](#4652) Fix valueFromAST variable own-property checks ([@abishekgiri](https://github.com/abishekgiri)) #### Docs 📝 * [#4706](#4706) Fix mistake in GraphQLError guidance ([@benjie](https://github.com/benjie)) #### Committers: 4 * Abishek Kumar Giri([@abishekgiri](https://github.com/abishekgiri)) * Benjie([@benjie](https://github.com/benjie)) * Benoit 'BoD' Lubek([@BoD](https://github.com/BoD)) * Nils-Börge Margotti([@Nols1000](https://github.com/Nols1000))

Forward-ports #4521 to v17. Co-authored-by: Benoit 'BoD' Lubek <BoD@JRAF.org>

## v17.0.0-beta.1 (2026-05-10) #### Breaking Change 💥 * [#4729](#4729) subscribe: replace perEventExecutor with mapSourceToResponseEvent ([@yaacovCR](https://github.com/yaacovCR)) * [#4730](#4730) chore(engines): drop Node 20 support ([@yaacovCR](https://github.com/yaacovCR)) * [#4731](#4731) refactor(execution): extract buildResolveInfo helper ([@yaacovCR](https://github.com/yaacovCR)) #### New Feature 🚀 * [#4733](#4733) feat: support node v26 ([@yaacovCR](https://github.com/yaacovCR)) #### Bug Fix 🐞 * [#4725](#4725) chore: forward-port directives on directive definitions (#4521) ([@yaacovCR](https://github.com/yaacovCR)) * [#4727](#4727) chore: forward-port configuration of the `ofType` introspection depth (#4317) ([@yaacovCR](https://github.com/yaacovCR)) #### Polish 💅 * [#4728](#4728) polish: group FRAGMENT_VARIABLE_DEFINITION with executable defs ([@yaacovCR](https://github.com/yaacovCR)) #### Internal 🏠 <details> <summary> 3 PRs were merged </summary> * [#4460](#4460) internal: use node experimental-strip-types instead of ts-node ([@yaacovCR](https://github.com/yaacovCR)) * [#4732](#4732) internal: use node test instead of mocha + c8 ([@yaacovCR](https://github.com/yaacovCR)) * [#4734](#4734) internal: add comment re: rewriteRelativeImportExtensions ([@yaacovCR](https://github.com/yaacovCR)) </details> #### Committers: 1 * Yaacov Rydzinski ([@yaacovCR](https://github.com/yaacovCR))

BoD requested a review from a team as a code owner January 6, 2026 17:46

This was referenced Jan 6, 2026

Add support for directives on directive definitions apollographql/apollo-kotlin#6803

Merged

Add support for directives on directive definitions graphql/graphql-spec#1206

Merged

martinbonnin reviewed Mar 17, 2026

View reviewed changes

Comment thread src/language/parser.ts Outdated

Comment thread src/language/parser.ts Outdated

This was referenced Mar 17, 2026

Add kotlin_labs/v0.7 apollographql/specs#81

Merged

Add @ignore apollographql/specs#82

Open

leebyron approved these changes Apr 2, 2026

View reviewed changes

jerelmiller reviewed Apr 3, 2026

View reviewed changes

BoD and others added 18 commits April 24, 2026 12:41

Add support for directives on directive definitions

531cbf4

Introspection related changes

e46ed2e

Add ParseOption.experimentalDirectivesOnDirectiveDefinition

d44ff03

npm run prettier

ca49ec5

fix test coverage

ac59fc1

fix imports

46a73d4

try to fix coverage

3d0a91c

try to make test coverage pass

8db915f

make prettier happy

64a5698

Introspection: change includeDeprecated: Boolean to Boolean!

e91532e

Fix indent

c2dbb78

Add an introspection test for multiple directives with arguments appl…

a15d81b

…ied to a directive

Update src/language/parser.ts

e34401a

Co-authored-by: Jerel Miller <jerelmiller@gmail.com>

Update src/language/parser.ts

9329e48

Co-authored-by: Jerel Miller <jerelmiller@gmail.com>

Update src/utilities/__tests__/extendSchema-test.ts

30f7d58

Co-authored-by: Jerel Miller <jerelmiller@gmail.com>

Update src/utilities/extendSchema.ts

edcc324

Co-authored-by: Jerel Miller <jerelmiller@gmail.com>

Update src/utilities/extendSchema.ts

788f090

Co-authored-by: Jerel Miller <jerelmiller@gmail.com>

Apply a few minor fixes suggested by Jerel

e230a8c

yaacovCR added 2 commits April 24, 2026 12:41

Forward parse options through buildSchema

1eb2a68

Preserve directive deprecations in extendSchema

a0349be

yaacovCR force-pushed the directive-on-directive-definitions branch 2 times, most recently from cd3b99e to 06a336c Compare April 24, 2026 09:46

yaacovCR added spec RFC Implementation of a proposed change to the GraphQL specification PR: feature 🚀 requires increase of "minor" version number labels Apr 24, 2026

yaacovCR force-pushed the directive-on-directive-definitions branch from 06a336c to a9e07a6 Compare April 24, 2026 09:52

yaacovCR added 6 commits April 24, 2026 17:45

Apply same-document directive extensions

7b9b581

Print deprecated directives in schemas

bd1929c

Add experimental directive deprecation to introspection queries

53b88d4

Import directive deprecations from introspection

da43e82

Refine directive introspection tests

a475823

Track directive definition directives across extensions

e287ba1

yaacovCR force-pushed the directive-on-directive-definitions branch from a9e07a6 to e287ba1 Compare April 24, 2026 14:47

yaacovCR approved these changes Apr 24, 2026

View reviewed changes

yaacovCR merged commit ad9c519 into graphql:16.x.x Apr 24, 2026
19 of 20 checks passed

yaacovCR changed the title ~~Add support for directives on directive definitions~~ Add experimental support for directives on directive definitions May 6, 2026

yaacovCR mentioned this pull request May 6, 2026

chore(release): v16.14.0 #4720

Merged

fisker mentioned this pull request May 7, 2026

Update dependency graphql to v16.14.0 prettier/prettier#19120

Merged

1 task

yaacovCR mentioned this pull request May 8, 2026

chore: forward-port directives on directive definitions (#4521) #4725

Merged

yaacovCR added a commit that referenced this pull request May 8, 2026

chore: forward-port directives on directive definitions (#4521) (#4725)

65fc947

Forward-ports #4521 to v17. Co-authored-by: Benoit 'BoD' Lubek <BoD@JRAF.org>

yaacovCR mentioned this pull request May 10, 2026

chore(release): v17.0.0-beta.1 #4735

Merged

fisker mentioned this pull request May 18, 2026

Graphql: Support directives on directive definitions prettier/prettier#19167

Closed

YBJ0000 mentioned this pull request May 19, 2026

Support directives on directive definitions in GraphQL prettier/prettier#19171

Merged

3 tasks

claude Bot mentioned this pull request May 21, 2026

fix(deps): update dependency graphql to v16.14.0 tailor-platform/sdk#1220

Merged

1 task

Cito mentioned this pull request Jun 11, 2026

3.2.11: @deprecated directive now appears in DIRECTIVE_DEFINITION locations, breaking GraphQL codegen tools graphql-python/graphql-core#268

Closed

daniellongcake mentioned this pull request Jun 12, 2026

fix: bump laboratory bundled graphql to ^16.14.0 graphql-hive/console#8139

Closed

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add experimental support for directives on directive definitions#4521

Add experimental support for directives on directive definitions#4521
yaacovCR merged 26 commits into
graphql:16.x.xgraphql/graphql-js:16.x.xfrom
BoD:directive-on-directive-definitionsBoD/graphql-js:directive-on-directive-definitionsCopy head branch name to clipboard

BoD commented Jan 6, 2026

Uh oh!

vercel Bot commented Jan 6, 2026

Uh oh!

Uh oh!

Uh oh!

leebyron commented Apr 2, 2026

Uh oh!

BoD commented Apr 3, 2026

Uh oh!

jerelmiller left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

benjie commented Apr 7, 2026

Uh oh!

yaacovCR commented Apr 24, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Search code, repositories, users, issues, pull requests...

Uh oh!

Conversation

BoD commented Jan 6, 2026

Disclaimer

Uh oh!

vercel Bot commented Jan 6, 2026

Uh oh!

Uh oh!

Uh oh!

leebyron commented Apr 2, 2026

Uh oh!

BoD commented Apr 3, 2026

Uh oh!

jerelmiller left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

benjie commented Apr 7, 2026

Uh oh!

yaacovCR commented Apr 24, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants