Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Redraw GeoJSON features after style changes#1732

Open
arpitagarwal1301 wants to merge 1 commit into
googlemaps:maingooglemaps/android-maps-utils:mainfrom
arpitagarwal1301:fix/1050-redraw-polygon-stylearpitagarwal1301/android-maps-utils:fix/1050-redraw-polygon-styleCopy head branch name to clipboard
Open

Redraw GeoJSON features after style changes#1732
arpitagarwal1301 wants to merge 1 commit into
googlemaps:maingooglemaps/android-maps-utils:mainfrom
arpitagarwal1301:fix/1050-redraw-polygon-stylearpitagarwal1301/android-maps-utils:fix/1050-redraw-polygon-styleCopy head branch name to clipboard

Conversation

@arpitagarwal1301

Copy link
Copy Markdown

Fixes #1050.

Observe legacy GeoJSON features so style and geometry changes invalidate the cached renderer model and redraw map objects with the updated values. Repeated insertion remains idempotent, removed features detach their observer, and null-geometry features remain safe across the layer lifecycle.

Multi-geometries now keep their rendered children under the parent feature, preserving complete removal and click lookup. Multi-polygons also carry their polygon style into the renderer.

Tests:

  • data module unit tests, including focused redraw and renderer ownership regressions
  • data module lint
  • data debug assembly
  • diff whitespace check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GeoJsonFeature.setPolygonStyle() doesn't redraw polygon if the feature was previously added via GeoJsonLayer.addFeature()

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.