Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
This repository was archived by the owner on Mar 31, 2026. It is now read-only.

feat: make tests run against environments other than prod#883

Merged
gcf-merge-on-green[bot] merged 70 commits into
googleapis:maingoogleapis/python-storage:mainfrom
rsaksham-dev:main_prrsaksham-dev/python-storage:main_prCopy head branch name to clipboard
Oct 21, 2022
Merged

feat: make tests run against environments other than prod#883
gcf-merge-on-green[bot] merged 70 commits into
googleapis:maingoogleapis/python-storage:mainfrom
rsaksham-dev:main_prrsaksham-dev/python-storage:main_prCopy head branch name to clipboard

Conversation

@rsaksham

@rsaksham rsaksham commented Oct 7, 2022

Copy link
Copy Markdown
Contributor

Made changes that override api endpoint information while triggering builds from kokoro .
All tests against prod are still successful.
Some system tests are currently incompatible with nonprod environments and hence are marked to be skipped if endpoint is being overriden.

@rsaksham rsaksham requested review from a team October 7, 2022 16:54
@product-auto-label product-auto-label Bot added size: m Pull request size is medium. api: storage Issues related to the googleapis/python-storage API. labels Oct 7, 2022
@rsaksham rsaksham changed the title Make tests run against environments other than prod feat: make tests run against environments other than prod Oct 10, 2022
Comment thread google/cloud/storage/blob.py
Comment thread .kokoro/build.sh
Comment thread google/cloud/storage/client.py Outdated
Comment thread tests/system/test__signing.py Outdated
Comment thread tests/system/test_bucket.py Outdated
Comment thread tests/system/test_client.py Outdated
Comment thread noxfile.py Outdated
@andrewsg andrewsg added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 17, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 17, 2022
chore(deps): update dependency pandas to v1.5.1 (googleapis#889)
@andrewsg andrewsg added the automerge Merge the pull request once unit tests and other checks pass. label Oct 20, 2022
@gcf-merge-on-green

Copy link
Copy Markdown
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green Bot removed the automerge Merge the pull request once unit tests and other checks pass. label Oct 20, 2022
docs: streamline docs for c.g.c migration (googleapis#876)
@frankyn frankyn added kokoro:force-run Add this label to force Kokoro to re-run the tests. automerge Merge the pull request once unit tests and other checks pass. labels Oct 20, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 20, 2022
@gcf-merge-on-green gcf-merge-on-green Bot merged commit 7dfeb62 into googleapis:main Oct 21, 2022
@gcf-merge-on-green gcf-merge-on-green Bot removed the automerge Merge the pull request once unit tests and other checks pass. label Oct 21, 2022
@rsaksham rsaksham deleted the main_pr branch December 8, 2022 10:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: storage Issues related to the googleapis/python-storage API. size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.