Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
This repository was archived by the owner on Mar 31, 2026. It is now read-only.

fix: retry client side requests timeout#727

Merged
cojenco merged 2 commits into
googleapis:maingoogleapis/python-storage:mainfrom
cojenco:timeout726cojenco/python-storage:timeout726Copy head branch name to clipboard
Mar 10, 2022
Merged

fix: retry client side requests timeout#727
cojenco merged 2 commits into
googleapis:maingoogleapis/python-storage:mainfrom
cojenco:timeout726cojenco/python-storage:timeout726Copy head branch name to clipboard

Conversation

@cojenco

@cojenco cojenco commented Mar 10, 2022

Copy link
Copy Markdown
Contributor

Add client-side requests.exceptions.Timeout to _RETRYABLE_TYPES
Test automatically covered here

Fixes #726 🦕

@cojenco cojenco requested review from a team March 10, 2022 01:02
@product-auto-label product-auto-label Bot added the api: storage Issues related to the googleapis/python-storage API. label Mar 10, 2022
mlazowik added a commit to qedsoftware/django-storages that referenced this pull request Mar 10, 2022
Revert this comment after a version of `google-cloud-storage` with
googleapis/python-storage#727 gets released and
ScanForm is updated to use it.
mlazowik added a commit to qedsoftware/django-storages that referenced this pull request Mar 10, 2022
Revert this comment after a version of `google-cloud-storage` with
googleapis/python-storage#727 gets released and
ScanForm is updated to use it.
mlazowik added a commit to qedsoftware/django-storages that referenced this pull request Mar 10, 2022
Revert this comment after a version of `google-cloud-storage` with
googleapis/python-storage#727 gets released and
ScanForm is updated to use it.
mlazowik added a commit to qedsoftware/django-storages that referenced this pull request Mar 10, 2022
Revert this comment after a version of `google-cloud-storage` with
googleapis/python-storage#727 gets released and
ScanForm is updated to use it.
mlazowik added a commit to qedsoftware/django-storages that referenced this pull request Mar 10, 2022
Revert this comment after a version of `google-cloud-storage` with
googleapis/python-storage#727 gets released and
ScanForm is updated to use it.
mlazowik added a commit to qedsoftware/django-storages that referenced this pull request Mar 10, 2022
* [gcloud] Retry on connection/read timeout

Revert this comment after a version of `google-cloud-storage` with
googleapis/python-storage#727 gets released and
ScanForm is updated to use it.

* [tests/gcloud] Add retry to expected params
@cojenco cojenco merged commit e0b3b35 into googleapis:main Mar 10, 2022
@cojenco cojenco deleted the timeout726 branch November 16, 2023 22:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: storage Issues related to the googleapis/python-storage API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Requests are not retried on connect/read timeouts

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.