Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
This repository was archived by the owner on Mar 31, 2026. It is now read-only.

feat: generate signed URLs for blobs/buckets using virtual hostname#58

Merged
tseaver merged 4 commits into
mastergoogleapis/python-storage:masterfrom
10-v4-signing-virtual-hostnamegoogleapis/python-storage:10-v4-signing-virtual-hostnameCopy head branch name to clipboard
Feb 13, 2020
Merged

feat: generate signed URLs for blobs/buckets using virtual hostname#58
tseaver merged 4 commits into
mastergoogleapis/python-storage:masterfrom
10-v4-signing-virtual-hostnamegoogleapis/python-storage:10-v4-signing-virtual-hostnameCopy head branch name to clipboard

Conversation

@tseaver

@tseaver tseaver commented Feb 13, 2020

Copy link
Copy Markdown
Contributor

Closes #10.

@tseaver tseaver requested review from crwilcox and frankyn February 13, 2020 01:37
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 13, 2020
@tseaver tseaver added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 13, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 13, 2020

@frankyn frankyn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit.

Comment thread google/cloud/storage/blob.py Outdated
version=None,
service_account_email=None,
access_token=None,
use_virtual_hostname=False,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use virtual_hosted_style instead.

Comment thread google/cloud/storage/blob.py Outdated
@tseaver tseaver force-pushed the 10-v4-signing-virtual-hostname branch from 5e949f2 to 3be7f6e Compare February 13, 2020 17:09
@tseaver tseaver force-pushed the 10-v4-signing-virtual-hostname branch from 3be7f6e to b75fd1d Compare February 13, 2020 19:39
@tseaver tseaver added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 13, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 13, 2020

@frankyn frankyn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tseaver tseaver merged commit 23df542 into master Feb 13, 2020
@tseaver tseaver deleted the 10-v4-signing-virtual-hostname branch February 13, 2020 20:32
cojenco pushed a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
…oogleapis#58)

* Add 'virtual_hosted_style' arg to 'Blob.generate_signed_url'
* Add 'virtual_hosted_style arg to 'Bucket.generate_signed_url'
cojenco pushed a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
…oogleapis#58)

* Add 'virtual_hosted_style' arg to 'Blob.generate_signed_url'
* Add 'virtual_hosted_style arg to 'Bucket.generate_signed_url'
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Storage] V4 Signature Support for virtual hosted-style signed

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.