This repository was archived by the owner on Mar 31, 2026. It is now read-only.
fix(tests): remove low version error assertion from iam conditions system tests#53
Merged
crwilcox merged 1 commit intoFeb 12, 2020
mastergoogleapis/python-storage:masterfrom
fix-iam-version-assertiongoogleapis/python-storage:fix-iam-version-assertionCopy head branch name to clipboard
Merged
fix(tests): remove low version error assertion from iam conditions system tests#53crwilcox merged 1 commit intomastergoogleapis/python-storage:masterfrom fix-iam-version-assertiongoogleapis/python-storage:fix-iam-version-assertionCopy head branch name to clipboard
crwilcox merged 1 commit into
mastergoogleapis/python-storage:masterfrom
fix-iam-version-assertiongoogleapis/python-storage:fix-iam-version-assertionCopy head branch name to clipboard
Conversation
tseaver
reviewed
Feb 12, 2020
| with pytest.raises( | ||
| BadRequest, match="cannot be less than the existing policy version" | ||
| ): | ||
| bucket.get_iam_policy() |
Contributor
There was a problem hiding this comment.
Do we have a definite confirmation that the backend no longer raises this exception under any circumstance?
Contributor
There was a problem hiding this comment.
We have an internal group with a conversation. Yes.
crwilcox
approved these changes
Feb 12, 2020
cojenco
pushed a commit
to cojenco/python-storage
that referenced
this pull request
Oct 13, 2021
cojenco
pushed a commit
to cojenco/python-storage
that referenced
this pull request
Oct 13, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #52