Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
This repository was archived by the owner on Mar 31, 2026. It is now read-only.

tests: harden 'test_bucket_w_default_event_based_hold'#468

Merged
tseaver merged 2 commits into
mastergoogleapis/python-storage:masterfrom
435-harden-default-event-based-hold-systestgoogleapis/python-storage:435-harden-default-event-based-hold-systestCopy head branch name to clipboard
Jun 21, 2021
Merged

tests: harden 'test_bucket_w_default_event_based_hold'#468
tseaver merged 2 commits into
mastergoogleapis/python-storage:masterfrom
435-harden-default-event-based-hold-systestgoogleapis/python-storage:435-harden-default-event-based-hold-systestCopy head branch name to clipboard

Conversation

@tseaver

@tseaver tseaver commented Jun 14, 2021

Copy link
Copy Markdown
Contributor

Reload blob w/ spurious EBH.

Closes #435.

@tseaver tseaver requested review from a team, andrewsg and frankyn June 14, 2021 16:48
@product-auto-label product-auto-label Bot added the api: storage Issues related to the googleapis/python-storage API. label Jun 14, 2021
@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Jun 14, 2021
@tseaver tseaver requested a review from chrisrossi June 14, 2021 20:03
@tseaver tseaver added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 18, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 18, 2021

@chrisrossi chrisrossi left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I wasn't really familiar with the full bag of tricks available in test_utils when working on NDB and ended up reinventing the wheel with some of the retry for eventual consistency stuff.

Reload blob w/ spurious EBH.

Closes #435.
@tseaver tseaver force-pushed the 435-harden-default-event-based-hold-systest branch from 68f67c8 to 618f480 Compare June 21, 2021 15:59
@tseaver tseaver added the automerge Merge the pull request once unit tests and other checks pass. label Jun 21, 2021
@tseaver tseaver removed the automerge Merge the pull request once unit tests and other checks pass. label Jun 21, 2021
@tseaver tseaver merged commit 3b06f9e into master Jun 21, 2021
@tseaver tseaver deleted the 435-harden-default-event-based-hold-systest branch June 21, 2021 16:22
cojenco pushed a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
cojenco pushed a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: storage Issues related to the googleapis/python-storage API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

'test_bucket_w_default_event_based_hold' systest is flaky

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.