Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
This repository was archived by the owner on Mar 31, 2026. It is now read-only.

refactor: add / use 'Client._delete_resource' method#442

Merged
tseaver merged 6 commits into
mastergoogleapis/python-storage:masterfrom
38-refactor-client-_delete_resourcegoogleapis/python-storage:38-refactor-client-_delete_resourceCopy head branch name to clipboard
Jun 7, 2021
Merged

refactor: add / use 'Client._delete_resource' method#442
tseaver merged 6 commits into
mastergoogleapis/python-storage:masterfrom
38-refactor-client-_delete_resourcegoogleapis/python-storage:38-refactor-client-_delete_resourceCopy head branch name to clipboard

Conversation

@tseaver

@tseaver tseaver commented May 10, 2021

Copy link
Copy Markdown
Contributor

Toward #38.

Note: this PR is based on afbf690 from PR #441. I will rebase to master when that PR lands. Done.

@tseaver tseaver requested review from a team, andrewsg and crwilcox May 10, 2021 18:27
@product-auto-label product-auto-label Bot added the api: storage Issues related to the googleapis/python-storage API. label May 10, 2021
@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label May 10, 2021
@tseaver tseaver marked this pull request as draft May 10, 2021 18:43
@tseaver tseaver force-pushed the 38-refactor-client-_delete_resource branch 3 times, most recently from 54c1d2d to 6244df0 Compare May 10, 2021 19:44
@tseaver tseaver added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 10, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 10, 2021
@tseaver tseaver force-pushed the 38-refactor-client-_delete_resource branch from 6244df0 to 7525c66 Compare June 7, 2021 19:27
@tseaver tseaver marked this pull request as ready for review June 7, 2021 19:27

@chrisrossi chrisrossi left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tseaver tseaver added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 7, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 7, 2021
@tseaver tseaver merged commit 94fd0ca into master Jun 7, 2021
@tseaver tseaver deleted the 38-refactor-client-_delete_resource branch June 7, 2021 20:12
cojenco pushed a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
Also, forward 'retry' through when deleting blobs during 'Bucket.delete'.

Toward googleapis#38.
cojenco pushed a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
Also, forward 'retry' through when deleting blobs during 'Bucket.delete'.

Toward googleapis#38.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: storage Issues related to the googleapis/python-storage API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.