Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
This repository was archived by the owner on Mar 31, 2026. It is now read-only.

docs: add clarification to batch module#1045

Merged
cojenco merged 5 commits into
googleapis:maingoogleapis/python-storage:mainfrom
cojenco:update-batch-docscojenco/python-storage:update-batch-docsCopy head branch name to clipboard
Jun 6, 2023
Merged

docs: add clarification to batch module#1045
cojenco merged 5 commits into
googleapis:maingoogleapis/python-storage:mainfrom
cojenco:update-batch-docscojenco/python-storage:update-batch-docsCopy head branch name to clipboard

Conversation

@cojenco

@cojenco cojenco commented May 19, 2023

Copy link
Copy Markdown
Contributor

This PR is intended to:

  • Clarify limited Batch support in the python client
  • Provide guidance on compatible use cases with batch requests
  • Add comment in batch sample

The current batch design does not support library methods whose return values depend on the response payload. Adding such support would be a huge undertaking, and is not prioritized at the moment. Incompatible use cases include but are not limited to:

  • error handling (i.e. blob.exists() or on_error callable in bucket.delete_blobs())
  • return value is extracted from the response payload (blob.rewrite() returns a 3-tuple, (rewrite_token, bytes_rewritten, object_size))

@product-auto-label product-auto-label Bot added size: s Pull request size is small. api: storage Issues related to the googleapis/python-storage API. labels May 19, 2023
@cojenco cojenco added the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 6, 2023
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 6, 2023
@cojenco cojenco marked this pull request as ready for review June 6, 2023 22:03
@cojenco cojenco requested a review from a team as a code owner June 6, 2023 22:03
@cojenco cojenco requested review from a team and parthea June 6, 2023 22:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: storage Issues related to the googleapis/python-storage API. size: s Pull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.