Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
This repository was archived by the owner on Mar 31, 2026. It is now read-only.

feat: add use_auth_w_custom_endpoint support#941

Merged
andrewsg merged 4 commits into
googleapis:maingoogleapis/python-storage:mainfrom
cojenco:useauthcojenco/python-storage:useauthCopy head branch name to clipboard
Dec 7, 2022
Merged

feat: add use_auth_w_custom_endpoint support#941
andrewsg merged 4 commits into
googleapis:maingoogleapis/python-storage:mainfrom
cojenco:useauthcojenco/python-storage:useauthCopy head branch name to clipboard

Conversation

@cojenco

@cojenco cojenco commented Nov 30, 2022

Copy link
Copy Markdown
Contributor

This adds a boolean flag use_auth_w_custom_endpoint - whether authentication is required with custom endpoints

  • only used when a custom endpoint in set in conjunction
  • defaults to True and uses authentication
  • if set to False, bypasses authentication

For backwards compatibility

  • by default, auth is bypassed when STORAGE_EMULATOR_HOST is set
  • add bool _is_emulator_set to improve readability

Refactored to ensure preprod testing is not adversely impacted

  • updated docstring to note internal testing used environment variables

Fixes #895 and internal b/258502260

@product-auto-label product-auto-label Bot added size: m Pull request size is medium. api: storage Issues related to the googleapis/python-storage API. labels Nov 30, 2022
@cojenco cojenco added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 1, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 1, 2022
@cojenco cojenco added the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 1, 2022
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 1, 2022
@cojenco cojenco marked this pull request as ready for review December 1, 2022 00:59
@cojenco cojenco requested review from a team December 1, 2022 00:59
@cojenco cojenco added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 1, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 1, 2022
@andrewsg andrewsg added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 7, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 7, 2022
@andrewsg andrewsg added the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 7, 2022
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 7, 2022
@andrewsg andrewsg merged commit 5291c08 into googleapis:main Dec 7, 2022
@cojenco cojenco deleted the useauth branch November 16, 2023 22:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: storage Issues related to the googleapis/python-storage API. size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enable authentication when a non-default api_endpoint is set (just like the googleapis/nodejs-storage)

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.