This repository was archived by the owner on Mar 31, 2026. It is now read-only.
fix(deps): drop pkg_resources#744
Merged
parthea merged 1 commit intoMar 30, 2022
maingoogleapis/python-storage:mainfrom
drop-dependency-on-pkg-resourcesgoogleapis/python-storage:drop-dependency-on-pkg-resourcesCopy head branch name to clipboard
Merged
fix(deps): drop pkg_resources#744parthea merged 1 commit intomaingoogleapis/python-storage:mainfrom drop-dependency-on-pkg-resourcesgoogleapis/python-storage:drop-dependency-on-pkg-resourcesCopy head branch name to clipboard
parthea merged 1 commit into
maingoogleapis/python-storage:mainfrom
drop-dependency-on-pkg-resourcesgoogleapis/python-storage:drop-dependency-on-pkg-resourcesCopy head branch name to clipboard
Conversation
busunkim96
approved these changes
Mar 30, 2022
Contributor
|
Thanks a lot, very helpful! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #740 🦕
google-cloud-core>=1.6.0is already listed as a dependency insetup.py. We should remove code that usespkg_resourcesto checkgoogle-cloud-core>=1.6.0.python-storage/setup.py
Line 33 in ad39116