Skip to content

Navigation Menu

Sign in

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

feat: added unit test with coverage of 68 % #611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
May 17, 2021
Merged

feat: added unit test with coverage of 68 % #611

merged 12 commits into from
May 17, 2021

Conversation

vi3k6i5
Copy link
Contributor

@vi3k6i5 vi3k6i5 commented Apr 22, 2021 •
edited
Loading

feat: added unit test with coverage of 60 %

@vi3k6i5 vi3k6i5 requested a review from a team as a code owner April 22, 2021 16:37
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/python-spanner-django API. label Apr 22, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Apr 22, 2021
@vi3k6i5 vi3k6i5 requested review from skuruppu and larkee April 22, 2021 16:37
@vi3k6i5 vi3k6i5 mentioned this pull request Apr 22, 2021
Closed
larkee
larkee reviewed Apr 23, 2021
View reviewed changes
tests/unit/django_spanner/models.py Show resolved Hide resolved
tests/unit/django_spanner/models.py Outdated Show resolved Hide resolved
@vi3k6i5 vi3k6i5 force-pushed the unit_tests_2 branch 2 times, most recently from b0f0e88 to 2391801 Compare April 24, 2021 18:16
@vi3k6i5 vi3k6i5 changed the title feat: added unit test with coverage of 75 % feat: added unit test with coverage of 70 % Apr 24, 2021
vi3k6i5 added 4 commits April 25, 2021 17:55
@vi3k6i5
Merge pull request #3 from googleapis/master
5ec9841 
fix: Remove un necessary file from code base (googleapis#608)
@vi3k6i5
Merge pull request #4 from googleapis/master
34c4dda 
feat: move migrations test modules to run against different emulator …
@vi3k6i5
Merge pull request #5 from googleapis/master
caf5a43 
feat: update workflow files to uniformly distribute the test modules …
@vi3k6i5
Merge pull request #6 from googleapis/master
129e41e 
feat: update docs and nox file to compile it (googleapis#610)
@vi3k6i5 vi3k6i5 requested review from larkee, thiagotnunes and c24t April 28, 2021 16:57
@vi3k6i5 vi3k6i5 linked an issue May 4, 2021 that may be closed by this pull request
Dedicated unit tests for django_spanner #541
Closed
c24t
c24t reviewed May 5, 2021
View reviewed changes
Copy link
Contributor

@c24t c24t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments on test organization and style, but the tests themselves look great and this is a big obvious improvement.

I'll have to take another pass to check the test logic in more detail, but the tests I've checked so far all LGTM.

@larkee may have some insight on test strategy from python-spanner.

tests/unit/django_spanner/models.py Outdated Show resolved Hide resolved
tests/unit/django_spanner/test_compiler.py Outdated Show resolved Hide resolved
tests/unit/django_spanner/test_compiler.py Outdated Show resolved Hide resolved
tests/unit/django_spanner/test_expressions.py Outdated Show resolved Hide resolved
tests/unit/django_spanner/models.py Outdated Show resolved Hide resolved
tests/unit/django_spanner/models.py Outdated Show resolved Hide resolved
@vi3k6i5 vi3k6i5 force-pushed the unit_tests_2 branch 2 times, most recently from 96170b4 to b4a8831 Compare May 5, 2021 13:48
@vi3k6i5 vi3k6i5 requested a review from c24t May 6, 2021 16:13
@vi3k6i5 vi3k6i5 changed the title feat: added unit test with coverage of 70 % feat: added unit test with coverage of 68 % May 7, 2021
c24t
c24t approved these changes May 17, 2021
View reviewed changes
Copy link
Contributor

@c24t c24t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests look great, thanks for the updates

@c24t c24t merged commit 92ad508 into googleapis:master May 17, 2021
This was referenced Apr 17, 2024
Closed
Closed
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c24t c24t c24t approved these changes

@skuruppu skuruppu Awaiting requested review from skuruppu

@larkee larkee Awaiting requested review from larkee

@thiagotnunes thiagotnunes Awaiting requested review from thiagotnunes

Assignees
No one assigned
Labels
api: spanner Issues related to the googleapis/python-spanner-django API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dedicated unit tests for django_spanner
3 participants
@vi3k6i5 @larkee @c24t
Morty Proxy This is a proxified and sanitized view of the page, visit original site.