Skip to content

Navigation Menu

Sign in

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

feat: add unit tests for schema, functions and introspection #606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 37 commits into from
Closed

feat: add unit tests for schema, functions and introspection #606

wants to merge 37 commits into from

Conversation

vi3k6i5
Copy link
Contributor

@vi3k6i5 vi3k6i5 commented Apr 6, 2021 •
edited
Loading

feat: add unit tests for schema, functions and introspection updated nox file for coverage and settings path for running unit tests.

@vi3k6i5 vi3k6i5 requested a review from a team as a code owner April 6, 2021 04:18
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/python-spanner-django API. label Apr 6, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Apr 6, 2021
busunkim96
busunkim96 reviewed Apr 6, 2021
View reviewed changes
noxfile.py Outdated Show resolved Hide resolved
@vi3k6i5 vi3k6i5 requested review from skuruppu and c24t April 7, 2021 03:17
thiagotnunes
thiagotnunes approved these changes Apr 12, 2021
View reviewed changes
Copy link

@thiagotnunes thiagotnunes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please wait for another approver since my python knowledge is limited

@vi3k6i5 vi3k6i5 requested a review from larkee April 12, 2021 08:03
@vi3k6i5 vi3k6i5 closed this Apr 22, 2021
@vi3k6i5
Copy link
Contributor Author

vi3k6i5 commented Apr 22, 2021 •
edited
Loading

Splitting this into 4 parts:

  1. feat: update docs and nox file to compile it #610 [ nox file config for docs]
  2. feat: added unit test with coverage of 68 % #611 [added unit tests with coverage 65 %]
  3. ci: add build for docfx and refactor settings for unit tests #626 [ Moved settings and conftest inside tests/unit/]
  4. current PR with unit tests for remaining unit test modules.

vi3k6i5 added 6 commits April 25, 2021 17:55
@vi3k6i5
Merge pull request #3 from googleapis/master
5ec9841 
fix: Remove un necessary file from code base (googleapis#608)
@vi3k6i5
Merge pull request #4 from googleapis/master
34c4dda 
feat: move migrations test modules to run against different emulator …
@vi3k6i5
Merge pull request #5 from googleapis/master
caf5a43 
feat: update workflow files to uniformly distribute the test modules …
@vi3k6i5
Merge pull request #6 from googleapis/master
129e41e 
feat: update docs and nox file to compile it (googleapis#610)
@vi3k6i5
feat: updated nox file for docs and docfx and added unit tests for cl…
fad6cf3 
…ient
@vi3k6i5
feat: added docfx build in nox file
cef35a5
@vi3k6i5 vi3k6i5 reopened this Apr 30, 2021
@vi3k6i5 vi3k6i5 removed request for skuruppu, larkee and c24t April 30, 2021 10:09
@vi3k6i5 vi3k6i5 changed the title feat: updated nox file for docs and docfx and added unit tests for client feat: add schema tests. Apr 30, 2021
@vi3k6i5 vi3k6i5 changed the title feat: add schema tests. feat: add schema tests Apr 30, 2021
@vi3k6i5 vi3k6i5 closed this Apr 30, 2021
@vi3k6i5 vi3k6i5 reopened this May 3, 2021
@vi3k6i5 vi3k6i5 changed the title feat: add schema tests feat: add unit tests for schema, functions and introspection May 18, 2021
@vi3k6i5
Copy link
Contributor Author

vi3k6i5 commented May 25, 2021

Split this PR into multiple PRs, so closing it.

@vi3k6i5 vi3k6i5 closed this May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thiagotnunes thiagotnunes Awaiting requested review from thiagotnunes

@skuruppu skuruppu Awaiting requested review from skuruppu

@c24t c24t Awaiting requested review from c24t

@larkee larkee Awaiting requested review from larkee

@busunkim96 busunkim96 Awaiting requested review from busunkim96

Assignees
No one assigned
Labels
api: spanner Issues related to the googleapis/python-spanner-django API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vi3k6i5 @thiagotnunes @busunkim96
Morty Proxy This is a proxified and sanitized view of the page, visit original site.