This repository was archived by the owner on Jun 8, 2026. It is now read-only.
chore: onboard to librarian#1454
Merged
parthea merged 49 commits intoNov 19, 2025
maingoogleapis/python-spanner:mainfrom
onboard-to-librariangoogleapis/python-spanner:onboard-to-librarianCopy head branch name to clipboard
Merged
chore: onboard to librarian#1454parthea merged 49 commits intomaingoogleapis/python-spanner:mainfrom onboard-to-librariangoogleapis/python-spanner:onboard-to-librarianCopy head branch name to clipboard
parthea merged 49 commits into
maingoogleapis/python-spanner:mainfrom
onboard-to-librariangoogleapis/python-spanner:onboard-to-librarianCopy head branch name to clipboard
Conversation
e75f0ce to
ff09a8a
Compare
ff09a8a to
8d3c937
Compare
a640ea4 to
7ad24b0
Compare
7ad24b0 to
0932137
Compare
rahul2393
previously approved these changes
Nov 6, 2025
0932137 to
bde609c
Compare
parthea
reviewed
Nov 7, 2025
bec92fc to
0fb058e
Compare
jskeet
reviewed
Nov 12, 2025
9a56faf to
4b3bc2c
Compare
rahul2393
previously approved these changes
Nov 14, 2025
Contributor
parthea
reviewed
Nov 18, 2025
parthea
left a comment
Contributor
There was a problem hiding this comment.
Please could you check if librarian release stage is working?
I encountered the following error
Traceback (most recent call last):
File "/app/./cli.py", line 1497, in handle_release_stage
_update_version_for_library(repo, output, path_to_library, version)
~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/app/./cli.py", line 1234, in _update_version_for_library
updated_content = _process_version_file(
_read_text_file(version_file), version, version_file
)
File "/app/./cli.py", line 1168, in _process_version_file
raise ValueError(
f"Could not find version string in {version_path}. File was not modified."
)
ValueError: Could not find version string in /repo/google/cloud/spanner_dbapi/version.py. File was not modified.
The above exception was the direct cause of the following exception:
Traceback (most recent call last):
File "/app/./cli.py", line 1592, in <module>
args.func(librarian=args.librarian, repo=args.repo, output=args.output)
~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/app/./cli.py", line 1509, in handle_release_stage
raise ValueError(f"Release stage failed: {e}") from e
ValueError: Release stage failed: Could not find version string in /repo/google/cloud/spanner_dbapi/version.py. File was not modified.
Contributor
|
I was able to run |
5044f23 to
07165db
Compare
parthea
approved these changes
Nov 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards googleapis/librarian#2460