Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings
This repository was archived by the owner on Mar 9, 2026. It is now read-only.

process: add type annotations check to CI runs#499

Merged
plamut merged 4 commits into
googleapis:maingoogleapis/python-pubsub:mainfrom
plamut:iss-477plamut/python-pubsub:iss-477Copy head branch name to clipboard
Sep 27, 2021
Merged

process: add type annotations check to CI runs#499
plamut merged 4 commits into
googleapis:maingoogleapis/python-pubsub:mainfrom
plamut:iss-477plamut/python-pubsub:iss-477Copy head branch name to clipboard

Conversation

@plamut

@plamut plamut commented Sep 17, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

Closes #477.

To verify, examine the CI logs and check that the pytype session has indeed run.

PR checklist:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 17, 2021
@product-auto-label product-auto-label Bot added the api: pubsub Issues related to the googleapis/python-pubsub API. label Sep 17, 2021
@plamut plamut changed the title process: add type checks to CI runs process: add type annotations check to CI runs Sep 17, 2021
@plamut plamut added the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 17, 2021
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 17, 2021
@plamut plamut added the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 17, 2021
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 17, 2021
@plamut plamut added the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 17, 2021
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 17, 2021
@plamut plamut marked this pull request as ready for review September 17, 2021 12:37
@plamut plamut requested review from a team, anguillanneuf and pradn September 17, 2021 12:37
@plamut

plamut commented Sep 17, 2021

Copy link
Copy Markdown
Contributor Author

FWIW, the samples failure is flakiness, will re-run when this is ready to be merged.

@plamut

plamut commented Sep 24, 2021

Copy link
Copy Markdown
Contributor Author

@pradn @anguillanneuf Friendly ping, this would be a useful addition, thanks!

@plamut plamut mentioned this pull request Sep 24, 2021
Closed
@plamut plamut added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 24, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 24, 2021
@plamut plamut added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Sep 24, 2021
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Sep 24, 2021
@plamut plamut added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 24, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 24, 2021
@plamut plamut merged commit 58552e7 into googleapis:main Sep 27, 2021
@plamut plamut deleted the iss-477 branch September 27, 2021 14:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@pradn pradn Awaiting requested review from pradn
@anguillanneuf anguillanneuf Awaiting requested review from anguillanneuf
1 more reviewer
@busunkim96 busunkim96 busunkim96 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: pubsub Issues related to the googleapis/python-pubsub API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add type annotation checks to CI

3 participants

@plamut @busunkim96 @yoshi-kokoro
Morty Proxy This is a proxified and sanitized view of the page, visit original site.