Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings
This repository was archived by the owner on Mar 9, 2026. It is now read-only.

fix: ignore future warnings on python versions#1546

Merged
abbrowne126 merged 15 commits into
maingoogleapis/python-pubsub:mainfrom
fix-future-warninggoogleapis/python-pubsub:fix-future-warningCopy head branch name to clipboard
Oct 28, 2025
Merged

fix: ignore future warnings on python versions#1546
abbrowne126 merged 15 commits into
maingoogleapis/python-pubsub:mainfrom
fix-future-warninggoogleapis/python-pubsub:fix-future-warningCopy head branch name to clipboard

Conversation

@abbrowne126

@abbrowne126 abbrowne126 commented Oct 28, 2025

Copy link
Copy Markdown
Collaborator

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1545 🦕

@abbrowne126
abbrowne126 requested review from a team October 28, 2025 14:47
@product-auto-label product-auto-label Bot added size: xs Pull request size is extra small. api: pubsub Issues related to the googleapis/python-pubsub API. labels Oct 28, 2025
@abbrowne126

abbrowne126 commented Oct 28, 2025 •
edited
Loading

Copy link
Copy Markdown
Collaborator Author

For some context, this PR in python API core caused several build failures (example). It's a warning but we error on warnings.

The python language team is going to handle language upgrades on this repo, and separately I believe this is intended for end users to see.

@abbrowne126 abbrowne126 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 28, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 28, 2025
@abbrowne126
abbrowne126 enabled auto-merge (squash) October 28, 2025 17:45
@abbrowne126
abbrowne126 merged commit 8e28dea into main Oct 28, 2025
30 checks passed
@abbrowne126
abbrowne126 deleted the fix-future-warning branch October 28, 2025 17:46
@release-please release-please Bot mentioned this pull request Oct 28, 2025
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@michaelpri10 michaelpri10 michaelpri10 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: pubsub Issues related to the googleapis/python-pubsub API. size: xs Pull request size is extra small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

The build failed

3 participants

@abbrowne126 @michaelpri10 @yoshi-kokoro
Morty Proxy This is a proxified and sanitized view of the page, visit original site.