fix: Change Log Severities for Terminated Streams by abbrowne126 · Pull Request #1433 · googleapis/python-pubsub

abbrowne126 · Jul 24, 2025

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
Ensure the tests and linter pass
Code coverage does not decrease (if any source code was changed)
Appropriate docs were updated (if necessary)

Fixes #1432 🦕

abbrowne126 · Jul 24, 2025

        # Terminate any non-API errors, or non-retryable errors (permission denied, unauthorized, etc.)
        if not is_api_error or isinstance(exception, _TERMINATING_STREAM_ERRORS):
-            _LOGGER.error("Observed terminating stream error %s", exception)
+            _LOGGER.debug("Observed terminating stream error %s", exception)


Note that this is being reverted to its previous severity

fix: change log severities for terminated streams

39e3009

abbrowne126 requested review from a team July 24, 2025 20:37

product-auto-label Bot added size: xs Pull request size is extra small. api: pubsub Issues related to the googleapis/python-pubsub API. labels Jul 24, 2025

abbrowne126 commented Jul 24, 2025

View reviewed changes

abbrowne126 requested a review from michaelpri10 July 24, 2025 20:38

abbrowne126 enabled auto-merge (squash) July 24, 2025 20:38

michaelpri10 approved these changes Jul 24, 2025

View reviewed changes

abbrowne126 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 24, 2025

yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 24, 2025

abbrowne126 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 28, 2025