Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings
This repository was archived by the owner on Apr 1, 2026. It is now read-only.

fix: add a callback function on flush_rows#796

Merged
mutianf merged 6 commits into
googleapis:maingoogleapis/python-bigtable:mainfrom
mutianf:batchermutianf/python-bigtable:batcherCopy head branch name to clipboard
Jun 8, 2023
Merged

fix: add a callback function on flush_rows#796
mutianf merged 6 commits into
googleapis:maingoogleapis/python-bigtable:mainfrom
mutianf:batchermutianf/python-bigtable:batcherCopy head branch name to clipboard

Conversation

@mutianf

@mutianf mutianf commented Jun 8, 2023

Copy link
Copy Markdown
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@mutianf mutianf requested review from a team June 8, 2023 16:30
@product-auto-label product-auto-label Bot added size: xs Pull request size is extra small. api: bigtable Issues related to the googleapis/python-bigtable API. labels Jun 8, 2023
igorbernstein2
igorbernstein2 suggested changes Jun 8, 2023
View reviewed changes
Comment thread google/cloud/bigtable/batcher.py Outdated
Comment thread google/cloud/bigtable/batcher.py Outdated
Comment thread google/cloud/bigtable/batcher.py Outdated
@product-auto-label product-auto-label Bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Jun 8, 2023
@mutianf mutianf merged commit 589aa5d into googleapis:main Jun 8, 2023
@mutianf mutianf deleted the batcher branch June 8, 2023 20:36
@release-please release-please Bot mentioned this pull request Jun 3, 2023
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers
@daniel-sanche daniel-sanche daniel-sanche approved these changes
@igorbernstein2 igorbernstein2 igorbernstein2 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigtable Issues related to the googleapis/python-bigtable API. size: s Pull request size is small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mutianf @daniel-sanche @igorbernstein2
Morty Proxy This is a proxified and sanitized view of the page, visit original site.