This repository was archived by the owner on Apr 1, 2026. It is now read-only.
feat!: microgenerator changes#203
Merged
kolea2 merged 35 commits intoFeb 11, 2021
googleapis:mastergoogleapis/python-bigtable:masterfrom
kolea2:microgenerator-changeskolea2/python-bigtable:microgenerator-changesCopy head branch name to clipboard
Merged
feat!: microgenerator changes#203kolea2 merged 35 commits intogoogleapis:mastergoogleapis/python-bigtable:masterfrom kolea2:microgenerator-changeskolea2/python-bigtable:microgenerator-changesCopy head branch name to clipboard
kolea2 merged 35 commits into
googleapis:mastergoogleapis/python-bigtable:masterfrom
kolea2:microgenerator-changeskolea2/python-bigtable:microgenerator-changesCopy head branch name to clipboard
Conversation
…generator-changes
…icrogenerator-changes
…icrogenerator-changes
|
Here is the summary of changes. You added 1 region tag.
You deleted 1 region tag.
This comment is generated by snippet-bot.
|
kolea2
commented
Feb 4, 2021
| max_age = _helpers._duration_pb_to_timedelta(gc_rule_pb.max_age) | ||
| return MaxAgeGCRule(max_age) | ||
| # todo check this is right | ||
| # max_age = _helpers._duration_pb_to_timedelta(gc_rule_pb.max_age) |
Contributor
Author
There was a problem hiding this comment.
question - is this change the correct new approach?
Contributor
There was a problem hiding this comment.
This might be good to dig into. protoplus knows timestamps, and I would expect gc_rule_pb.max_age to be one, without the helper? Though timedelta isn't timestamp and I don't recall offhand if that is implemented. to be safe, I'd expect gc_rule_pb._pb.max_age to allow the other code to stay the same?
kolea2
commented
Feb 4, 2021
crwilcox
reviewed
Feb 5, 2021
…icrogenerator-changes
crwilcox
approved these changes
Feb 8, 2021
kolea2
commented
Feb 10, 2021
kolea2
commented
Feb 10, 2021
| if self.timeout is not None: | ||
| kwargs["timeout"] = timeout.ExponentialTimeout(deadline=self.timeout) | ||
|
|
||
| # todo confirm this change |
Contributor
Author
There was a problem hiding this comment.
@crwilcox another todo I missed - I think my concern here was the mutate rows call wasn't wrapped in a request={... but I think due to the code below this (will need to expand) this works as expected. LMK if you have a concern
| bigtable_table_admin_client_config as table_admin_config, | ||
| ) | ||
|
|
||
| # from google.cloud.bigtable_admin_v2.gapic import ( |
| bigtable_table_admin_pb2.ListBackupsRequest( | ||
| parent=parent, filter=backups_filter, **kwargs | ||
| ), | ||
| retry=mock.ANY, |
Contributor
Author
There was a problem hiding this comment.
@crwilcox one last thing to point out - the last few params were now removed from the assertion because we are no longer using the inner_api_calls to get the result, let me know if oyu think this should still be here.
crwilcox
approved these changes
Feb 10, 2021
Merged
tseaver
added a commit
that referenced
this pull request
Dec 8, 2021
parthea
added a commit
that referenced
this pull request
Jan 11, 2022
parthea
added a commit
that referenced
this pull request
Jan 11, 2022
parthea
added a commit
that referenced
this pull request
Jan 12, 2022
* ci: run samples under Python 3.9 / 3.10
Refresh each sample's noxfile via:
----------------------------- %< -----------------------------
$ for noxfile in samples/*/noxfile.py; do
echo "Refreshing $noxfile";
wget -O $noxfile https://github.com/GoogleCloudPlatform/python-docs-samples/raw/main/noxfile-template.py
echo "Blackening samples for $noxfile"
nox -f $noxfile -s blacken
done
----------------------------- %< -----------------------------
Closes #477.
* fix: disable install-from-sorce for beam sample
Per #203.
* fix: skip beam sample for Python 3.10
Beam-related wheels are not yet available.
* fix: also refresh noxfiles for 'samples/snippets'
* ci: don't enforce type hints on old samples
* resolve issue where samples templates are not updated
* 🦉 Updates from OwlBot
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
* resolve mypy error Name __path__ already defined
* add workaroud from PR #203
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release-As: v2.0.0-dev1
Regen the client with the microgenerator. This requires the client to be used with Python >= 3.6
There are a few outstanding questions I have that I will annotate in the PR. Most important changes to pay attention to are the handwritten client and test layers.