Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
This repository was archived by the owner on Apr 1, 2026. It is now read-only.

fix: retry cancelled errors#1235

Merged
daniel-sanche merged 2 commits into
maingoogleapis/python-bigtable:mainfrom
fix_flakesgoogleapis/python-bigtable:fix_flakesCopy head branch name to clipboard
Dec 4, 2025
Merged

fix: retry cancelled errors#1235
daniel-sanche merged 2 commits into
maingoogleapis/python-bigtable:mainfrom
fix_flakesgoogleapis/python-bigtable:fix_flakesCopy head branch name to clipboard

Conversation

@daniel-sanche

Copy link
Copy Markdown
Contributor

There's an internal race condition where when an rpc hits the timeout limit, it sometimes receives a DEADLINE_EXCEEDED, but sometimes receives a CANCELLED error. This PR marks CANCELLED as retryable, so this situation will always eventually reach a DEADLINE_EXCEEDED state.

This will fix the flake currently seen in the conformance tests

@product-auto-label product-auto-label Bot added size: xs Pull request size is extra small. api: bigtable Issues related to the googleapis/python-bigtable API. labels Nov 20, 2025
@product-auto-label product-auto-label Bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Nov 21, 2025
@daniel-sanche daniel-sanche changed the title [DRAFT] fix: retry cancelled errors fix: retry cancelled errors Nov 21, 2025
@daniel-sanche daniel-sanche added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 21, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 21, 2025
@daniel-sanche daniel-sanche added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 21, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 21, 2025
@daniel-sanche daniel-sanche added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 4, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 4, 2025
@daniel-sanche daniel-sanche marked this pull request as ready for review December 4, 2025 18:29
@daniel-sanche daniel-sanche requested review from a team December 4, 2025 18:29
@daniel-sanche daniel-sanche merged commit e3fd5d8 into main Dec 4, 2025
33 checks passed
@daniel-sanche daniel-sanche deleted the fix_flakes branch December 4, 2025 19:19
daniel-sanche added a commit that referenced this pull request Dec 16, 2025
PR created by the Librarian CLI to initialize a release. Merging this PR
will auto trigger a release.

Librarian Version: v0.7.0
Language Image:
us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:b8058df4c45e9a6e07f6b4d65b458d0d059241dd34c814f151c8bf6b89211209
<details><summary>google-cloud-bigtable: 2.35.0</summary>

##
[2.35.0](v2.34.0...v2.35.0)
(2025-12-16)

### Features

* add basic interceptor to client (#1206)
([6561cfa](6561cfac))

* Add encodings for STRUCT and the Timestamp type
([72dfdc4](72dfdc44))

* add PeerInfo proto in Bigtable API
([72dfdc4](72dfdc44))

* Add Type API updates needed to support structured keys in materialized
views
([72dfdc4](72dfdc44))

* support mTLS certificates when available (#1249)
([ca20219](ca20219c))

### Bug Fixes

* re-export AddToCell for consistency (#1241)
([2a5baf1](2a5baf11))

* async client uses fixed grace period (#1236)
([544db1c](544db1cd))

* Deprecate credentials_file argument
([72dfdc4](72dfdc44))

* Add ReadRows/SampleRowKeys bindings for materialized views
([72dfdc4](72dfdc44))

* retry cancelled errors (#1235)
([e3fd5d8](e3fd5d86))

</details>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: bigtable Issues related to the googleapis/python-bigtable API. size: s Pull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.