Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
This repository was archived by the owner on May 7, 2026. It is now read-only.

fix: handle aggregate operations on empty selections#2510

Merged
shuoweil merged 8 commits into
maingoogleapis/python-bigquery-dataframes:mainfrom
shuowei-fix-compiler-syntax-guardsgoogleapis/python-bigquery-dataframes:shuowei-fix-compiler-syntax-guardsCopy head branch name to clipboard
Mar 31, 2026
Merged

fix: handle aggregate operations on empty selections#2510
shuoweil merged 8 commits into
maingoogleapis/python-bigquery-dataframes:mainfrom
shuowei-fix-compiler-syntax-guardsgoogleapis/python-bigquery-dataframes:shuowei-fix-compiler-syntax-guardsCopy head branch name to clipboard

Conversation

@shuoweil

Copy link
Copy Markdown
Contributor

SQL generator output fallbacks (SELECT 1 placeholder).

Fixes #<452681068> 🦕

@shuoweil shuoweil self-assigned this Mar 12, 2026
@shuoweil shuoweil requested review from a team as code owners March 12, 2026 02:45
@shuoweil shuoweil requested a review from mpovoa March 12, 2026 02:45
@product-auto-label product-auto-label Bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Mar 12, 2026
@shuoweil shuoweil requested review from TrevorBergeron and chelsea-lin and removed request for mpovoa March 12, 2026 02:46
@shuoweil shuoweil added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 12, 2026
@bigframes-bot bigframes-bot removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 12, 2026

@chelsea-lin chelsea-lin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Comment thread tests/system/small/test_dataframe.py Outdated
def test_dataframe_count_empty_selection_succeeds(session):
# Tests that aggregate ops on empty selections don't trigger invalid empty SELECT syntax
df = session.read_gbq("SELECT 1 AS int_col")
empty_df = df[[]]

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alternatively: empty_df = bpd.DataFrame()

@shuoweil shuoweil enabled auto-merge (squash) March 18, 2026 17:44
@shuoweil shuoweil force-pushed the shuowei-fix-compiler-syntax-guards branch from 452b3fa to 1a1fc23 Compare March 19, 2026 21:54
@shuoweil shuoweil force-pushed the shuowei-fix-compiler-syntax-guards branch from 45570a3 to d4ac766 Compare March 24, 2026 18:01
@shuoweil shuoweil disabled auto-merge March 24, 2026 19:09
@shuoweil shuoweil force-pushed the shuowei-fix-compiler-syntax-guards branch from 71c4ec8 to f34aba9 Compare March 24, 2026 21:48
@shuoweil shuoweil force-pushed the shuowei-fix-compiler-syntax-guards branch from d84a522 to 9acd05e Compare March 31, 2026 18:37
@shuoweil shuoweil merged commit 34fb5da into main Mar 31, 2026
20 of 25 checks passed
@shuoweil shuoweil deleted the shuowei-fix-compiler-syntax-guards branch March 31, 2026 20:39
sycai added a commit that referenced this pull request Apr 1, 2026
PR created by the Librarian CLI to initialize a release. Merging this PR
will auto trigger a release.

Librarian Version: v0.7.0
Language Image:
us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:160860d189ff1c2f7515638478823712fa5b243e27ccc33a2728669fa1e2ed0c
<details><summary>bigframes: 2.39.0</summary>

##
[2.39.0](v2.38.0...v2.39.0)
(2026-03-31)

### Features

* add `df.bigquery.ai.forecast` method to pandas dataframe accessor
(#2518)
([1126cec](1126cec9))

* support full round-trip persistence for multimodal reference cols
(#2511)
([494a0a1](494a0a11))

* expose DataFrame.bigquery in both pandas and bigframes DataFrames
(#2533)
([69fe317](69fe3176))

### Bug Fixes

* to_gbq may swap data columns when replace table (#2532)
([17ecc65](17ecc65e))

* handle aggregate operations on empty selections (#2510)
([34fb5da](34fb5daa))

* Localize BigQuery log suppression for gbq.py (#2541)
([af49ca2](af49ca29))

* Respect remote function config changes even if logic unchanged (#2512)
([b952428](b9524284))

* support melting empty DataFrames without crashing (#2509)
([e8c4603](e8c46032))

### Performance Improvements

* Make executor data uploads async internally (#2529)
([96597f0](96597f0b))

### Documentation

* gemini retouch of the index page for seo (#2514)
([2e5311e](2e5311e2))

* Rename Blob column references to ObjectRef column (#2535)
([44e0ffd](44e0ffd9))

</details>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: s Pull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.