Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings
This repository was archived by the owner on May 7, 2026. It is now read-only.

fix: allow IsInOp with same dtypes regardless nullable#2466

Merged
chelsea-lin merged 1 commit into
maingoogleapis/python-bigquery-dataframes:mainfrom
main_chelsealin_tpch_regressionsgoogleapis/python-bigquery-dataframes:main_chelsealin_tpch_regressionsCopy head branch name to clipboard
Feb 20, 2026
Merged

fix: allow IsInOp with same dtypes regardless nullable#2466
chelsea-lin merged 1 commit into
maingoogleapis/python-bigquery-dataframes:mainfrom
main_chelsealin_tpch_regressionsgoogleapis/python-bigquery-dataframes:main_chelsealin_tpch_regressionsCopy head branch name to clipboard

Conversation

@chelsea-lin

@chelsea-lin chelsea-lin commented Feb 18, 2026

Copy link
Copy Markdown
Contributor
  • Update Ibis isin_op_impl to compare types by name, allowing comparisons between columns and literals with different nullability.
  • Update SQLGlot IsInOp implementation to use dtypes.can_compare for more robust type compatibility checking.
  • Improve dtypes.can_compare to gracefully handle type coercion failures.
  • Migrate TPCH verification script to tests/system/large/test_tpch.py for better integration with the test suite.

Fixes 485642936 🦕

@product-auto-label product-auto-label Bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Feb 18, 2026
@chelsea-lin
fix: allow IsIn Ops with same dtypes regardless nullable
30361b7 
- Update Ibis isin_op_impl to compare types by name, allowing comparisons between columns and literals with different nullability.
- Update SQLGlot IsInOp implementation to use dtypes.can_compare for more robust type compatibility checking.
- Improve dtypes.can_compare to gracefully handle type coercion failures.
- Migrate TPCH verification script to tests/system/large/test_tpch.py for better integration with the test suite.
@chelsea-lin chelsea-lin force-pushed the main_chelsealin_tpch_regressions branch from 1d180eb to 30361b7 Compare February 18, 2026 22:50
@chelsea-lin chelsea-lin marked this pull request as ready for review February 18, 2026 23:39
@chelsea-lin chelsea-lin requested a review from a team as a code owner February 18, 2026 23:39
@chelsea-lin chelsea-lin merged commit 1d81b41 into main Feb 20, 2026
23 of 24 checks passed
@chelsea-lin chelsea-lin deleted the main_chelsealin_tpch_regressions branch February 20, 2026 00:26
@chelsea-lin chelsea-lin mentioned this pull request Mar 3, 2026
Merged
chelsea-lin added a commit that referenced this pull request Mar 4, 2026
@chelsea-lin
chore: librarian release pull request: 20260303T181914Z (#2489)
a8ba879 
PR created by the Librarian CLI to initialize a release. Merging this PR
will auto trigger a release.

Librarian Version: v0.8.3
Language Image:
us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:160860d189ff1c2f7515638478823712fa5b243e27ccc33a2728669fa1e2ed0c
<details><summary>bigframes: v2.37.0</summary>

##
[v2.37.0](v2.36.0...v2.37.0)
(2026-03-03)

### Features

* Add cloud_function_cpus option to remote_function (#2475)
([4caf74c](4caf74cc))

* add display.render_mode to control DataFrame/Series visualization
(#2413)
([7813eaa](7813eaa6))

* Support pd.col expressions with .loc and getitem (#2473)
([ae5c8b3](ae5c8b32))

* add support for Python 3.14 (#2232)
([c25a6d0](c25a6d01))

* Support pd.col simple aggregates (#2480)
([cb00daa](cb00daab))

* add dt.tz_localize() (#2469)
([f70f93a](f70f93a1))

* Update bigquery.ai.generate_table output_schema to allow Mapping type
(#2463)
([f7fd189](f7fd1895))

### Bug Fixes

* upload local data through write API if nested JSONs detected (#2478)
([01dc5a3](01dc5a34))

* allow IsInOp with same dtypes regardless nullable (#2466)
([1d81b41](1d81b414))

### Documentation

* Add code examples to configuration docstrings (#2352)
([3c21993](3c21993e))

* Move readme content to new User Guide section (#2464)
([61a9484](61a94845))

* add code sample and docstring for bpd.options.experiments.sql_compiler
(#2474)
([867951b](867951bc))

* use direct API for image (#2465)
([8a1a82f](8a1a82f7))

* Fix recall_score doc example (#2477)
([a6f499c](a6f499c1))

* Skip inherited methods, use autosummary only for big classes (#2470)
([a951249](a9512498))

* add bigframes default connection warning (#2471)
([f1bbba2](f1bbba23))

</details>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@TrevorBergeron TrevorBergeron TrevorBergeron approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@shobsi shobsi

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chelsea-lin @TrevorBergeron @shobsi
Morty Proxy This is a proxified and sanitized view of the page, visit original site.