Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
This repository was archived by the owner on May 7, 2026. It is now read-only.

feat: Configure Biome for Consistent Code Style#2364

Merged
shuoweil merged 2 commits into
maingoogleapis/python-bigquery-dataframes:mainfrom
shuowei-configure-biomegoogleapis/python-bigquery-dataframes:shuowei-configure-biomeCopy head branch name to clipboard
Jan 5, 2026
Merged

feat: Configure Biome for Consistent Code Style#2364
shuoweil merged 2 commits into
maingoogleapis/python-bigquery-dataframes:mainfrom
shuowei-configure-biomegoogleapis/python-bigquery-dataframes:shuowei-configure-biomeCopy head branch name to clipboard

Conversation

@shuoweil

@shuoweil shuoweil commented Jan 5, 2026

Copy link
Copy Markdown
Contributor

This PR adds biome.json to enforce consistent 2-space indentation and single quotes for JavaScript and CSS files. This aligns with project style guides, automates formatting via pre-commit hooks, and prevents manual style changes from being overwritten.

Currently, our Biome setup relies on default settings, which violates Google coding style guidelines. Specifically:

  • Quotation Marks: Biome's defaults do not enforce single quotes for JavaScript (as per js_style.txt: screen/8NaEr3SswN6qx6D) and CSS property values (as per css_style.txt: screen/9KCh8ZVQ4ByPeDR).
  • Indentation: Biome's defaults do not consistently enforce 2 spaces for indentation across HTML (screen/97ZZstQc4iH4Dsb) and JavaScript (screen/3crxm5peLvRE2kj) files.

This configuration explicitly sets these rules to ensure full compliance.

Benefits:

  • Consistent and readable JS/CSS code.
  • Automated style enforcement.
  • Reduced developer friction.

To Test:
Make a style-violating change in a .js or .css file and attempt to commit. Biome should automatically reformat it.

Fixes #<issue_number_goes_here> 🦕

@shuoweil shuoweil self-assigned this Jan 5, 2026
@shuoweil shuoweil requested review from a team and jialuoo January 5, 2026 21:47
@product-auto-label product-auto-label Bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Jan 5, 2026
@shuoweil shuoweil requested a review from tswast January 5, 2026 21:47
@shuoweil shuoweil force-pushed the shuowei-configure-biome branch from 4e1f971 to 2bdf31a Compare January 5, 2026 21:56
@shuoweil shuoweil enabled auto-merge (squash) January 5, 2026 22:03
@shuoweil shuoweil merged commit 81e27b3 into main Jan 5, 2026
20 of 26 checks passed
@shuoweil shuoweil deleted the shuowei-configure-biome branch January 5, 2026 22:26
chelsea-lin added a commit that referenced this pull request Jan 22, 2026
PR created by the Librarian CLI to initialize a release. Merging this PR
will auto trigger a release.

Librarian Version: v0.7.0
Language Image:
us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:e7cc6823efb073a8a26e7cefdd869f12ec228abfbd2a44aa9a7eacc284023677
<details><summary>bigframes: 2.33.0</summary>

##
[2.33.0](v2.32.0...v2.33.0)
(2026-01-22)

### Features

* add bigquery.ml.transform function (#2394)
([1f9ee37](1f9ee373))

* Add dark mode to anywidget mode (#2365)
([2763b41](2763b41d))

* Add max_columns control for anywidget mode (#2374)
([34b5975](34b5975f))

* Configure Biome for Consistent Code Style (#2364)
([81e27b3](81e27b3d))

* Add BigQuery ObjectRef functions to `bigframes.bigquery.obj` (#2380)
([9c3bbc3](9c3bbc36))

* Stabilize interactive table height to prevent notebook layout shifts
(#2378)
([a634e97](a634e976))

### Bug Fixes

* implement retry logic for cloud function endpoint fetching (#2369)
([0f593c2](0f593c27))

* Throw if write api commit op has stream_errors (#2385)
([7abfef0](7abfef05))

### Performance Improvements

* Avoid requery for some result downsample methods (#2219)
([95763ff](95763ff2))

</details>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: s Pull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.