Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings
This repository was archived by the owner on May 7, 2026. It is now read-only.

feat: add fit_predict method to ml unsupervised models#2320

Merged
GarrettWu merged 2 commits into
maingoogleapis/python-bigquery-dataframes:mainfrom
garrettwu-kmeansgoogleapis/python-bigquery-dataframes:garrettwu-kmeansCopy head branch name to clipboard
Dec 11, 2025
Merged

feat: add fit_predict method to ml unsupervised models#2320
GarrettWu merged 2 commits into
maingoogleapis/python-bigquery-dataframes:mainfrom
garrettwu-kmeansgoogleapis/python-bigquery-dataframes:garrettwu-kmeansCopy head branch name to clipboard

Conversation

@GarrettWu

@GarrettWu GarrettWu commented Dec 10, 2025

Copy link
Copy Markdown
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@GarrettWu GarrettWu requested a review from sycai December 10, 2025 00:02
@GarrettWu GarrettWu self-assigned this Dec 10, 2025
@GarrettWu GarrettWu requested review from a team December 10, 2025 00:02
@product-auto-label product-auto-label Bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Dec 10, 2025
@review-notebook-app

review-notebook-app Bot commented Dec 10, 2025

Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@shuoweil

shuoweil commented Dec 10, 2025

Copy link
Copy Markdown
Contributor

Please check the failed presubmit

@GarrettWu

GarrettWu commented Dec 10, 2025

Copy link
Copy Markdown
Contributor Author

Please check the failed presubmit

Unrelated

FAILED tests/system/small/test_series.py::test_timestamp_astype_string - Asse...
FAILED tests/system/small/test_series.py::test_float_astype_json[raise] - Ass...
FAILED tests/system/small/test_series.py::test_float_astype_json[null] - Asse...
FAILED tests/system/small/test_series.py::test_float_astype_json_str - Assert...
FAILED tests/system/small/test_series.py::test_string_astype_json_in_safe_mode
FAILED tests/system/small/test_series.py::test_string_astype_json_raise_error
FAILED tests/system/small/test_series.py::test_json_astype_others_raise_error[to_float]
FAILED tests/system/small/test_series.py::test_json_astype_others_raise_error[to_bool]
FAILED tests/system/small/test_series.py::test_json_astype_others_raise_error[to_string]
FAILED tests/system/small/test_series.py::test_json_astype_others_in_safe_mode[to_int]
FAILED tests/system/small/test_series.py::test_json_astype_others_in_safe_mode[to_float]
FAILED tests/system/small/test_series.py::test_json_astype_others_in_safe_mode[to_bool]
FAILED tests/system/small/test_series.py::test_json_astype_others_in_safe_mode[to_string]

@GarrettWu GarrettWu added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 10, 2025
@GarrettWu GarrettWu enabled auto-merge (squash) December 10, 2025 19:02
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 10, 2025
@GarrettWu GarrettWu added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 10, 2025
@bigframes-bot bigframes-bot removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 10, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 10, 2025
@GarrettWu GarrettWu added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 11, 2025
@bigframes-bot bigframes-bot removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 11, 2025
@GarrettWu GarrettWu merged commit 59df7f7 into main Dec 11, 2025
19 of 25 checks passed
@GarrettWu GarrettWu deleted the garrettwu-kmeans branch December 11, 2025 20:04
@ldetmer ldetmer mentioned this pull request Jan 6, 2026
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@sycai sycai sycai approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@GarrettWu GarrettWu

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@GarrettWu @shuoweil @sycai @yoshi-kokoro @bigframes-bot
Morty Proxy This is a proxified and sanitized view of the page, visit original site.