Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
This repository was archived by the owner on May 7, 2026. It is now read-only.

feat: enable SQLGlot compiler as default#2248

Closed
chelsea-lin wants to merge 2 commits into
maingoogleapis/python-bigquery-dataframes:mainfrom
main_chelsealin_enablesqlglot2googleapis/python-bigquery-dataframes:main_chelsealin_enablesqlglot2Copy head branch name to clipboard
Closed

feat: enable SQLGlot compiler as default#2248
chelsea-lin wants to merge 2 commits into
maingoogleapis/python-bigquery-dataframes:mainfrom
main_chelsealin_enablesqlglot2googleapis/python-bigquery-dataframes:main_chelsealin_enablesqlglot2Copy head branch name to clipboard

Conversation

@chelsea-lin

@chelsea-lin chelsea-lin commented Nov 10, 2025

Copy link
Copy Markdown
Contributor

Fixes internal issue 417774347🦕

@product-auto-label product-auto-label Bot added size: l Pull request size is large. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Nov 10, 2025
@chelsea-lin chelsea-lin force-pushed the main_chelsealin_enablesqlglot2 branch from 7a011e1 to d634b06 Compare November 11, 2025 00:22
@product-auto-label product-auto-label Bot added size: xs Pull request size is extra small. and removed size: l Pull request size is large. labels Nov 11, 2025
@chelsea-lin chelsea-lin added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Nov 12, 2025
@chelsea-lin chelsea-lin force-pushed the main_chelsealin_enablesqlglot2 branch from d634b06 to c90c084 Compare November 12, 2025 20:59
@chelsea-lin chelsea-lin force-pushed the main_chelsealin_enablesqlglot2 branch from c90c084 to eb8e92c Compare November 24, 2025 23:12
chelsea-lin added a commit that referenced this pull request Nov 25, 2025
…2292)

This change aims to fix the tests failing in #2248 because of a 1-based
indexing error.

Fixes internal issue 417774347 🦕
@chelsea-lin chelsea-lin force-pushed the main_chelsealin_enablesqlglot2 branch 2 times, most recently from 689b4e4 to 39096e5 Compare November 25, 2025 21:49
chelsea-lin added a commit that referenced this pull request Nov 26, 2025
…sqlglot compiler (#2297)

This change aims to fix the `to_datetime` related tests failing in
#2248.

Fixes internal issue 417774347 🦕
chelsea-lin added a commit that referenced this pull request Nov 26, 2025
This change aims to fix the `test_timestamp_series_diff_agg` test
failing in #2248.

Fixes internal issue 417774347 🦕
@chelsea-lin chelsea-lin force-pushed the main_chelsealin_enablesqlglot2 branch from 39096e5 to 2f63b1f Compare November 26, 2025 23:28
chelsea-lin added a commit that referenced this pull request Dec 1, 2025
This change aims to fix some string-related tests failing in #2248.

Fixes internal issue 417774347🦕
@chelsea-lin chelsea-lin force-pushed the main_chelsealin_enablesqlglot2 branch from 2f63b1f to 6d1b653 Compare December 15, 2025 05:52
chelsea-lin added a commit that referenced this pull request Dec 16, 2025
This change aims to fix some string-related tests failing in #2248.

Fixes internal issue 417774347🦕
@chelsea-lin chelsea-lin force-pushed the main_chelsealin_enablesqlglot2 branch from 6d1b653 to 82ac904 Compare December 16, 2025 02:41
shuoweil pushed a commit that referenced this pull request Dec 17, 2025
This change aims to fix some string-related tests failing in #2248.

Fixes internal issue 417774347 🦕
chelsea-lin added a commit that referenced this pull request Dec 19, 2025
…t _literal (#2337)

This change can resolve two doctests failures in #2248:
`groupby.GroupBy.rank` and `bigframes.ml.metrics.roc_curve`

Fixes internal issue 417774347🦕

---------

Co-authored-by: Shenyang Cai <sycai@users.noreply.github.com>
shuoweil pushed a commit that referenced this pull request Dec 19, 2025
…t _literal (#2337)

This change can resolve two doctests failures in #2248:
`groupby.GroupBy.rank` and `bigframes.ml.metrics.roc_curve`

Fixes internal issue 417774347🦕

---------

Co-authored-by: Shenyang Cai <sycai@users.noreply.github.com>
tswast pushed a commit that referenced this pull request Dec 19, 2025
This change can resolve three doctests failures in #2248: 
- Added `to_json` support to the compiler backend.
- Fixed minor bugs on AI ops
- Fixed minor bugs on windows compiler

Fixes internal issue 417774347 🦕
chelsea-lin added a commit that referenced this pull request Jan 15, 2026
…ps (#2381)

This change adds null literal checks during the compilation of eq, ne
and map ops. This aims to resolve the
`test_series_replace_nans_with_pd_na` failure reported in #2248.

Fixes internal issue 417774347 🦕
chelsea-lin added a commit that referenced this pull request Jan 15, 2026
This change fixes several aggregation-related test failures in #2248 by
including the following operators:
- `agg_ops.DiffOp`: Fixes test_date_series_diff_agg
- `agg_ops.AllOp/AnyOp`: Fixes test_list_apply_callable
- `agg_ops.QuantileOp`: Fixes test_dataframe_aggregates_median
- `agg_ops.ProductOp`: Fixes test_dataframe_groupby_analytic

Fixes internal issue 417774347 🦕
@chelsea-lin chelsea-lin force-pushed the main_chelsealin_enablesqlglot2 branch from 3972dc7 to f900cdb Compare January 16, 2026 06:46
chelsea-lin added a commit that referenced this pull request Jan 21, 2026
This change fixes several numeric_ops test failures in #2248

Fixes internal issue 417774347 🦕
@chelsea-lin chelsea-lin force-pushed the main_chelsealin_enablesqlglot2 branch from 6adb0e1 to 3325427 Compare January 23, 2026 17:51
chelsea-lin added a commit that referenced this pull request Jan 27, 2026
…mpiler (#2406)

This change fixes several presubmit test failures in #2248

Fixes internal issue 417774347 🦕
@chelsea-lin chelsea-lin force-pushed the main_chelsealin_enablesqlglot2 branch from 3325427 to d370151 Compare January 27, 2026 22:57
chelsea-lin added a commit that referenced this pull request Jan 29, 2026
… sqlglot (#2414)

This change fixes the `test_concat_dataframe` failures in #2248

Fixes internal issue 417774347 🦕
@chelsea-lin chelsea-lin force-pushed the main_chelsealin_enablesqlglot2 branch 2 times, most recently from 426b6a3 to c31a9d7 Compare February 2, 2026 22:36
@product-auto-label product-auto-label Bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Feb 2, 2026
@chelsea-lin chelsea-lin force-pushed the main_chelsealin_enablesqlglot2 branch 2 times, most recently from 34eb4fb to 5a146b3 Compare February 10, 2026 18:58
chelsea-lin added a commit that referenced this pull request Feb 17, 2026
This change fixes the`test_read_gbq_w_ambigous_name` failures in #2248

Fixes internal issue 417774347 🦕
@chelsea-lin chelsea-lin force-pushed the main_chelsealin_enablesqlglot2 branch from 2db43e5 to 5c0a461 Compare February 18, 2026 22:59
@chalmerlowe

Copy link
Copy Markdown

Migration Notice: This library is moving to the google-cloud-python monorepo soon.

We closed this PR due to inactivity to ensure a clean migration. Please re-open this work in the new monorepo once the migration is complete!

@chalmerlowe chalmerlowe closed this Mar 2, 2026
@chelsea-lin chelsea-lin reopened this Mar 5, 2026
@chelsea-lin chelsea-lin force-pushed the main_chelsealin_enablesqlglot2 branch 2 times, most recently from b7453ea to 67210d9 Compare March 10, 2026 22:02
@chelsea-lin chelsea-lin force-pushed the main_chelsealin_enablesqlglot2 branch from 67210d9 to e3511d7 Compare March 16, 2026 17:12
@tswast

tswast commented Apr 1, 2026

Copy link
Copy Markdown
Contributor

Closing. Let's move this over to https://github.com/googleapis/google-cloud-python once googleapis/google-cloud-python#16493 merges.

@tswast tswast closed this Apr 1, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. do not merge Indicates a pull request not ready for merge, due to either quality or timing. size: s Pull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.