Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
This repository was archived by the owner on May 7, 2026. It is now read-only.

feat: Replace ML.GENERATE_TEXT with AI.GENERATE for audio transcription#2151

Merged
shuoweil merged 4 commits into
maingoogleapis/python-bigquery-dataframes:mainfrom
shuowei-audio-transcribe-part-order-modegoogleapis/python-bigquery-dataframes:shuowei-audio-transcribe-part-order-modeCopy head branch name to clipboard
Oct 9, 2025
Merged

feat: Replace ML.GENERATE_TEXT with AI.GENERATE for audio transcription#2151
shuoweil merged 4 commits into
maingoogleapis/python-bigquery-dataframes:mainfrom
shuowei-audio-transcribe-part-order-modegoogleapis/python-bigquery-dataframes:shuowei-audio-transcribe-part-order-modeCopy head branch name to clipboard

Conversation

@shuoweil

@shuoweil shuoweil commented Oct 8, 2025

Copy link
Copy Markdown
Contributor

This change allows us to use partial ordering mode, since ML.GENERATE_TEXT is TVF.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<430572560> 🦕

@shuoweil shuoweil requested a review from sycai October 8, 2025 09:28
@shuoweil shuoweil self-assigned this Oct 8, 2025
@shuoweil shuoweil requested review from a team October 8, 2025 09:28
@product-auto-label product-auto-label Bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Oct 8, 2025
sycai
sycai previously approved these changes Oct 8, 2025
Comment thread bigframes/operations/blob.py Outdated
prompt=(prompt_text, audio_runtime),
connection_id=connection,
endpoint=model_name,
request_type="unspecified",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: "unspecified" is the default value, so maybe we can just remove this line?

@shuoweil shuoweil force-pushed the shuowei-audio-transcribe-part-order-mode branch from 9276c56 to 9179103 Compare October 9, 2025 04:37
@shuoweil shuoweil enabled auto-merge (squash) October 9, 2025 05:05
@shuoweil shuoweil requested a review from sycai October 9, 2025 05:05
@review-notebook-app

Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@product-auto-label product-auto-label Bot added size: l Pull request size is large. and removed size: s Pull request size is small. labels Oct 9, 2025
@shuoweil shuoweil merged commit a410d0a into main Oct 9, 2025
24 of 25 checks passed
@shuoweil shuoweil deleted the shuowei-audio-transcribe-part-order-mode branch October 9, 2025 17:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: l Pull request size is large.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.