Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings
This repository was archived by the owner on May 7, 2026. It is now read-only.

fix: join on, how args are now positional#2140

Merged
TrevorBergeron merged 1 commit into
maingoogleapis/python-bigquery-dataframes:mainfrom
fix_join_argsgoogleapis/python-bigquery-dataframes:fix_join_argsCopy head branch name to clipboard
Oct 7, 2025
Merged

fix: join on, how args are now positional#2140
TrevorBergeron merged 1 commit into
maingoogleapis/python-bigquery-dataframes:mainfrom
fix_join_argsgoogleapis/python-bigquery-dataframes:fix_join_argsCopy head branch name to clipboard

Conversation

@TrevorBergeron

@TrevorBergeron TrevorBergeron commented Oct 6, 2025

Copy link
Copy Markdown
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #415111654 🦕

@TrevorBergeron TrevorBergeron requested review from a team and shuoweil October 6, 2025 20:20
@product-auto-label product-auto-label Bot added the size: xs Pull request size is extra small. label Oct 6, 2025
@product-auto-label product-auto-label Bot added the api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. label Oct 6, 2025
@TrevorBergeron TrevorBergeron merged commit b711815 into main Oct 7, 2025
19 of 25 checks passed
@TrevorBergeron TrevorBergeron deleted the fix_join_args branch October 7, 2025 16:41
@release-please release-please Bot mentioned this pull request Oct 7, 2025
Merged
sycai pushed a commit that referenced this pull request Oct 7, 2025
@TrevorBergeron @sycai
fix: join on, how args are now positional (#2140)
780ff9f
sycai added a commit that referenced this pull request Oct 7, 2025
@sycai @TrevorBergeron
feat: add output_schema parameter to ai.generate() (#2139)
ef0b0b7 
* feat: add output_schema to ai.generate()

* fix lint

* fix lint

* fix test

* fix mypy

* fix lint

* code optimization

* fix tests

* support case-insensitive type parsing

* fix test

* fix: Fix row count local execution bug (#2133)

* fix: join on, how args are now positional (#2140)

---------

Co-authored-by: TrevorBergeron <tbergeron@google.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@shuoweil shuoweil Awaiting requested review from shuoweil
1 more reviewer
@sycai sycai sycai approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@chelsea-lin chelsea-lin

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: xs Pull request size is extra small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@TrevorBergeron @sycai @chelsea-lin
Morty Proxy This is a proxified and sanitized view of the page, visit original site.