Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

chore: test fix. #1121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 29, 2024
Merged

chore: test fix. #1121

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
72aed57
chore: test fix.
Genesis929 Oct 29, 2024
bf8dfd0
Merge branch 'main' into warning_test_fix
Genesis929 Oct 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion 2 tests/system/small/test_session.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -399,7 +399,7 @@ def test_read_gbq_twice_with_same_timestamp(session, penguins_table_id):
)
def test_read_gbq_on_linked_dataset_warns(session, source_table):
with warnings.catch_warnings(record=True) as warned:
session.read_gbq(source_table)
session.read_gbq(source_table, use_cache=False)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we know why a cached read will trigger one extra warning?

Copy link
Collaborator Author

@Genesis929 Genesis929 Oct 29, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If a table is read multiple times in the same session, there will be warning messages except for the first read. And there are two tests that include step to read this table, most likely in the same session. That I think is the cause.

Check b/375664942 for details.

assert len(warned) == 1
assert warned[0].category == bigframes.exceptions.TimeTravelDisabledWarning

Expand Down
Morty Proxy This is a proxified and sanitized view of the page, visit original site.