chore: test fix. #1121
Merged
chore: test fix. #1121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chelsea-lin
approved these changes
Oct 29, 2024
shobsi
reviewed
Oct 29, 2024
| @@ -399,7 +399,7 @@ def test_read_gbq_twice_with_same_timestamp(session, penguins_table_id): | ||
| ) | ||
| def test_read_gbq_on_linked_dataset_warns(session, source_table): | ||
| with warnings.catch_warnings(record=True) as warned: | ||
| session.read_gbq(source_table) | ||
| session.read_gbq(source_table, use_cache=False) |
There was a problem hiding this comment.
Do we know why a cached read will trigger one extra warning?
There was a problem hiding this comment.
If a table is read multiple times in the same session, there will be warning messages except for the first read. And there are two tests that include step to read this table, most likely in the same session. That I think is the cause.
Check b/375664942 for details.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕