This repository was archived by the owner on May 7, 2026. It is now read-only.
fix: Correct connection normalization in blob system tests#2222
Merged
shuoweil merged 3 commits intoNov 3, 2025
maingoogleapis/python-bigquery-dataframes:mainfrom
shuowei-connection-name-testcasegoogleapis/python-bigquery-dataframes:shuowei-connection-name-testcaseCopy head branch name to clipboard
Merged
fix: Correct connection normalization in blob system tests#2222shuoweil merged 3 commits intomaingoogleapis/python-bigquery-dataframes:mainfrom shuowei-connection-name-testcasegoogleapis/python-bigquery-dataframes:shuowei-connection-name-testcaseCopy head branch name to clipboard
shuoweil merged 3 commits into
maingoogleapis/python-bigquery-dataframes:mainfrom
shuowei-connection-name-testcasegoogleapis/python-bigquery-dataframes:shuowei-connection-name-testcaseCopy head branch name to clipboard
Conversation
chelsea-lin
suggested changes
Nov 3, 2025
chelsea-lin
left a comment
Contributor
There was a problem hiding this comment.
The commit should be named starting with the "fix: " prefix.
6d5bf49 to
6cf4111
Compare
6cf4111 to
680bf5d
Compare
chelsea-lin
approved these changes
Nov 3, 2025
GarrettWu
added a commit
that referenced
this pull request
Nov 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses a bug in the blob storage system tests where the normalize_connection_id fixture was incorrectly implemented, causing several tests to fail.
The key changes include:
Fixes #<457416070> 🦕