Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings
This repository was archived by the owner on May 7, 2026. It is now read-only.

fix: only show JSON dtype warning when accessing dtypes directly#2136

Merged
tswast merged 5 commits into
maingoogleapis/python-bigquery-dataframes:mainfrom
b449153433-JSON-warninggoogleapis/python-bigquery-dataframes:b449153433-JSON-warningCopy head branch name to clipboard
Oct 6, 2025
Merged

fix: only show JSON dtype warning when accessing dtypes directly#2136
tswast merged 5 commits into
maingoogleapis/python-bigquery-dataframes:mainfrom
b449153433-JSON-warninggoogleapis/python-bigquery-dataframes:b449153433-JSON-warningCopy head branch name to clipboard

Conversation

@tswast

@tswast tswast commented Oct 3, 2025

Copy link
Copy Markdown
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes internal issue b/449153433 🦕

@tswast tswast requested review from a team and chelsea-lin October 3, 2025 19:27
@product-auto-label product-auto-label Bot added the size: m Pull request size is medium. label Oct 3, 2025
@product-auto-label product-auto-label Bot added the api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. label Oct 3, 2025
chelsea-lin
chelsea-lin previously approved these changes Oct 3, 2025
View reviewed changes
Comment thread tests/unit/test_dtypes.py Outdated
@@ -0,0 +1,73 @@
# Copyright 2023 Google LLC

@chelsea-lin chelsea-lin Oct 3, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: 2025

@chelsea-lin chelsea-lin Oct 3, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@tswast tswast merged commit eca22ee into main Oct 6, 2025
24 of 25 checks passed
@tswast tswast deleted the b449153433-JSON-warning branch October 6, 2025 17:31
@release-please release-please Bot mentioned this pull request Oct 6, 2025
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@chelsea-lin chelsea-lin chelsea-lin approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@shobsi shobsi

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tswast @chelsea-lin @shobsi
Morty Proxy This is a proxified and sanitized view of the page, visit original site.