Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
This repository was archived by the owner on May 7, 2026. It is now read-only.

fix: Fix internal type errors with temporal accessors#2125

Merged
TrevorBergeron merged 4 commits into
maingoogleapis/python-bigquery-dataframes:mainfrom
cast_ibis_error_fixgoogleapis/python-bigquery-dataframes:cast_ibis_error_fixCopy head branch name to clipboard
Oct 2, 2025
Merged

fix: Fix internal type errors with temporal accessors#2125
TrevorBergeron merged 4 commits into
maingoogleapis/python-bigquery-dataframes:mainfrom
cast_ibis_error_fixgoogleapis/python-bigquery-dataframes:cast_ibis_error_fixCopy head branch name to clipboard

Conversation

@TrevorBergeron

@TrevorBergeron TrevorBergeron commented Sep 29, 2025

Copy link
Copy Markdown
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #448160916 🦕

@TrevorBergeron TrevorBergeron requested review from a team and sycai September 29, 2025 20:39
@product-auto-label product-auto-label Bot added the size: s Pull request size is small. label Sep 29, 2025
@product-auto-label product-auto-label Bot added the api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. label Sep 29, 2025
sycai
sycai previously approved these changes Sep 29, 2025
@tswast

tswast commented Sep 30, 2025

Copy link
Copy Markdown
Contributor

Failed presubmits look relevant:

FAILED tests/system/small/operations/test_datetimes.py::test_timedelta_can_cast_after_dt_accessor
FAILED tests/system/small/operations/test_dates.py::test_date_can_cast_after_accessor

@tswast

tswast commented Sep 30, 2025

Copy link
Copy Markdown
Contributor
[bigframes/operations/type.py:47](https://cs.corp.google.com/piper///depot/google3/bigframes/operations/type.py?l=47): in meth
    return self.output_type(input_types[0])
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

self = FixedOutputType(type_predicate=<function is_date_like at 0x15272d518310>, fixed_type=Int64Dtype(), description='date-like')
input_type = duration[us][pyarrow]

    def output_type(self, input_type: ExpressionType) -> ExpressionType:
        if (input_type is not None) and not self.type_predicate(input_type):
>           raise TypeError(
                f"Type {input_type} is not supported. Type must be {self.description}"
            )
E           TypeError: Type duration[us][pyarrow] is not supported. Type must be date-like

@sycai

sycai commented Oct 1, 2025

Copy link
Copy Markdown
Contributor

Looks like the presubmit still failed

E AttributeError: 'ArrowExtensionArray' object has no attribute 'tz'

@TrevorBergeron TrevorBergeron requested a review from sycai October 2, 2025 17:11
@TrevorBergeron TrevorBergeron merged commit c390da1 into main Oct 2, 2025
25 checks passed
@TrevorBergeron TrevorBergeron deleted the cast_ibis_error_fix branch October 2, 2025 17:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: s Pull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.