Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings
This repository was archived by the owner on Mar 6, 2026. It is now read-only.

docs: update intersphinx links#404

Merged
tswast merged 4 commits into
googleapis:mastergoogleapis/python-bigquery:masterfrom
tswast:restore-py_samplestswast/python-bigquery:restore-py_samplesCopy head branch name to clipboard
Dec 7, 2020
Merged

docs: update intersphinx links#404
tswast merged 4 commits into
googleapis:mastergoogleapis/python-bigquery:masterfrom
tswast:restore-py_samplestswast/python-bigquery:restore-py_samplesCopy head branch name to clipboard

Conversation

@tswast

@tswast tswast commented Nov 30, 2020

Copy link
Copy Markdown
Contributor

Also, updates synth.py to avoid manual hacks, such as to work around the breaking change in #316 until we figure out how to use proto-plus classes directly #319.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Closes #336
Closes #325
Closes #316

@tswast tswast requested a review from a team November 30, 2020 16:51
@tswast tswast requested a review from a team as a code owner November 30, 2020 16:51
@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 30, 2020
@product-auto-label product-auto-label Bot added the api: bigquery Issues related to the googleapis/python-bigquery API. label Nov 30, 2020
@tswast

tswast commented Nov 30, 2020

Copy link
Copy Markdown
Contributor Author

Generated with python -m synthtool on the latest synthtool commit, checked out locally.

@tswast tswast requested a review from shollyman December 2, 2020 19:36
shollyman
shollyman approved these changes Dec 2, 2020
View reviewed changes

@shollyman shollyman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, with the caveat that it's not clear what here is generated vs manual config change.

@tswast tswast requested review from crwilcox and steffnay December 3, 2020 15:28
@tswast

tswast commented Dec 3, 2020

Copy link
Copy Markdown
Contributor Author

Thanks @shollyman

The only manual changes are to synth.py

@tswast tswast merged commit a9d8ae8 into googleapis:master Dec 7, 2020
@tswast tswast deleted the restore-py_samples branch December 7, 2020 18:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@stephaniewang526 stephaniewang526 Awaiting requested review from stephaniewang526
@steffnay steffnay Awaiting requested review from steffnay
@crwilcox crwilcox Awaiting requested review from crwilcox
1 more reviewer
@shollyman shollyman shollyman approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigquery Issues related to the googleapis/python-bigquery API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tswast @shollyman
Morty Proxy This is a proxified and sanitized view of the page, visit original site.