Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings
This repository was archived by the owner on Mar 6, 2026. It is now read-only.

test: fix DML system tests#388

Merged
steffnay merged 2 commits into
googleapis:mastergoogleapis/python-bigquery:masterfrom
tswast:issue377-dbapi-system-teststswast/python-bigquery:issue377-dbapi-system-testsCopy head branch name to clipboard
Nov 16, 2020
Merged

test: fix DML system tests#388
steffnay merged 2 commits into
googleapis:mastergoogleapis/python-bigquery:masterfrom
tswast:issue377-dbapi-system-teststswast/python-bigquery:issue377-dbapi-system-testsCopy head branch name to clipboard

Conversation

@tswast

@tswast tswast commented Nov 16, 2020

Copy link
Copy Markdown
Contributor

Merge-on-green-bot "helpfully" merged #387 with failing system tests. This PR cleans those up.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Towards #377 🦕

@tswast tswast requested review from a team and pmakani November 16, 2020 16:15
@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 16, 2020
@product-auto-label product-auto-label Bot added the api: bigquery Issues related to the googleapis/python-bigquery API. label Nov 16, 2020
@tswast tswast requested review from shollyman and removed request for pmakani November 16, 2020 16:16
@tswast tswast mentioned this pull request Nov 16, 2020
Closed
@tswast tswast requested review from steffnay and removed request for shollyman November 16, 2020 19:31
@steffnay steffnay merged commit 9a9db54 into googleapis:master Nov 16, 2020
@tswast tswast deleted the issue377-dbapi-system-tests branch November 16, 2020 20:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@steffnay steffnay steffnay approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigquery Issues related to the googleapis/python-bigquery API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tswast @steffnay
Morty Proxy This is a proxified and sanitized view of the page, visit original site.