Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings
This repository was archived by the owner on Mar 6, 2026. It is now read-only.

fix(DBAPI): keep cursor hot when statement is a script#386

Closed
mistercrunch wants to merge 1 commit into
googleapis:mastergoogleapis/python-bigquery:masterfrom
mistercrunch:script_isnt_dmlmistercrunch/python-bigquery:script_isnt_dmlCopy head branch name to clipboard
Closed

fix(DBAPI): keep cursor hot when statement is a script#386
mistercrunch wants to merge 1 commit into
googleapis:mastergoogleapis/python-bigquery:masterfrom
mistercrunch:script_isnt_dmlmistercrunch/python-bigquery:script_isnt_dmlCopy head branch name to clipboard

Conversation

@mistercrunch

@mistercrunch mistercrunch commented Nov 12, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

all the details here: #377

I guess technically a script isn't DML :trollface:

@product-auto-label product-auto-label Bot added the api: bigquery Issues related to the googleapis/python-bigquery API. label Nov 12, 2020
@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 12, 2020
@mistercrunch mistercrunch mentioned this pull request Nov 12, 2020
Closed
@tswast

tswast commented Nov 12, 2020

Copy link
Copy Markdown
Contributor

Makes sense to me.

Actually, we can probably consider removing the is_dml logic altogether now that we moved to getQueryResults instead of tabledata.list (#375). The destination table of a DML query would return a non-null value that was unreadable or would return nonsense with DML (and some DDL) queries. Before we do that, I'll want to double-check that we have a system test for this case. (I think a DDL to CREATE VIEW would be a good choice for that)

@mistercrunch

mistercrunch commented Nov 13, 2020

Copy link
Copy Markdown
Contributor Author

Superseded by #387

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

api: bigquery Issues related to the googleapis/python-bigquery API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mistercrunch @tswast
Morty Proxy This is a proxified and sanitized view of the page, visit original site.