Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings
This repository was archived by the owner on Mar 6, 2026. It is now read-only.

feat: support insertAll for range#1909

Merged
Linchin merged 6 commits into
googleapis:maingoogleapis/python-bigquery:mainfrom
Linchin:range_insertallLinchin/python-bigquery:range_insertallCopy head branch name to clipboard
May 6, 2024
Merged

feat: support insertAll for range#1909
Linchin merged 6 commits into
googleapis:maingoogleapis/python-bigquery:mainfrom
Linchin:range_insertallLinchin/python-bigquery:range_insertallCopy head branch name to clipboard

Conversation

@Linchin

@Linchin Linchin commented May 2, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • _range_to_json() conversion function to use insertAll
  • unit tests for the conversion functions
  • supports client.insert_rows() with dictionary and tuple, in the form of a dictionary or string literal
  • adds client.insert_rows() unit tests for each case we do not test for inserting different data types here
  • client.insert_row_from_dataframe() just works

Fixes #<issue_number_goes_here> 🦕

@Linchin Linchin requested review from a team and leahecole May 2, 2024 22:09
@product-auto-label product-auto-label Bot added the size: m Pull request size is medium. label May 2, 2024
@product-auto-label product-auto-label Bot added the api: bigquery Issues related to the googleapis/python-bigquery API. label May 2, 2024
@Linchin Linchin removed the request for review from leahecole May 2, 2024 22:12
@Linchin Linchin added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label May 2, 2024
@Linchin Linchin assigned shollyman and unassigned mrfaizal May 2, 2024
alvarowolfx
alvarowolfx approved these changes May 3, 2024
View reviewed changes
Comment thread google/cloud/bigquery/_helpers.py Outdated
@Linchin Linchin removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label May 3, 2024
@Linchin Linchin merged commit 74e75e8 into googleapis:main May 6, 2024
@release-please release-please Bot mentioned this pull request May 6, 2024
Merged
@Linchin Linchin mentioned this pull request May 10, 2024
Closed
6 tasks
This was referenced May 21, 2024
Closed
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@PhongChuong PhongChuong Awaiting requested review from PhongChuong
@shollyman shollyman Awaiting requested review from shollyman
1 more reviewer
@alvarowolfx alvarowolfx alvarowolfx approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@shollyman shollyman

Labels

api: bigquery Issues related to the googleapis/python-bigquery API. size: m Pull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Linchin @alvarowolfx @tswast @shollyman @mrfaizal
Morty Proxy This is a proxified and sanitized view of the page, visit original site.