Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings
This repository was archived by the owner on Mar 6, 2026. It is now read-only.

fix: Remove duplicate key time_partitioning from Table._PROPERTY_TO_A…#1898

Merged
gcf-merge-on-green[bot] merged 5 commits into
googleapis:maingoogleapis/python-bigquery:mainfrom
toransahu:torantoransahu/python-bigquery:toranCopy head branch name to clipboard
Apr 12, 2024
Merged

fix: Remove duplicate key time_partitioning from Table._PROPERTY_TO_A…#1898
gcf-merge-on-green[bot] merged 5 commits into
googleapis:maingoogleapis/python-bigquery:mainfrom
toransahu:torantoransahu/python-bigquery:toranCopy head branch name to clipboard

Conversation

@toransahu

@toransahu toransahu commented Apr 12, 2024

Copy link
Copy Markdown
Contributor

…PI_FIELD

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@toransahu toransahu requested review from a team and farhan0102 April 12, 2024 12:09
@product-auto-label product-auto-label Bot added size: xs Pull request size is extra small. api: bigquery Issues related to the googleapis/python-bigquery API. labels Apr 12, 2024
@chalmerlowe chalmerlowe added the kokoro:run Add this label to force Kokoro to re-run the tests. label Apr 12, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Apr 12, 2024
@chalmerlowe chalmerlowe self-assigned this Apr 12, 2024
@chalmerlowe chalmerlowe added the automerge Merge the pull request once unit tests and other checks pass. label Apr 12, 2024
chalmerlowe
chalmerlowe approved these changes Apr 12, 2024
View reviewed changes

@chalmerlowe chalmerlowe left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@chalmerlowe chalmerlowe added the kokoro:run Add this label to force Kokoro to re-run the tests. label Apr 12, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Apr 12, 2024
@gcf-merge-on-green gcf-merge-on-green Bot merged commit 82ae908 into googleapis:main Apr 12, 2024
@gcf-merge-on-green gcf-merge-on-green Bot removed the automerge Merge the pull request once unit tests and other checks pass. label Apr 12, 2024
@release-please release-please Bot mentioned this pull request Apr 12, 2024
Merged
This was referenced Apr 23, 2024
Closed
Closed
Closed
@toransahu toransahu deleted the toran branch June 6, 2024 06:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@farhan0102 farhan0102 Awaiting requested review from farhan0102
1 more reviewer
@chalmerlowe chalmerlowe chalmerlowe approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@chalmerlowe chalmerlowe

Labels

api: bigquery Issues related to the googleapis/python-bigquery API. size: xs Pull request size is extra small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@toransahu @chalmerlowe @yoshi-kokoro
Morty Proxy This is a proxified and sanitized view of the page, visit original site.