Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings
This repository was archived by the owner on Mar 6, 2026. It is now read-only.

feat: adds billing to opentel#1889

Merged
Linchin merged 2 commits into
maingoogleapis/python-bigquery:mainfrom
feat-adds-billinggoogleapis/python-bigquery:feat-adds-billingCopy head branch name to clipboard
Apr 11, 2024
Merged

feat: adds billing to opentel#1889
Linchin merged 2 commits into
maingoogleapis/python-bigquery:mainfrom
feat-adds-billinggoogleapis/python-bigquery:feat-adds-billingCopy head branch name to clipboard

Conversation

@chalmerlowe

@chalmerlowe chalmerlowe commented Apr 8, 2024

Copy link
Copy Markdown
Collaborator

This PR adds two features to OpenTelemetry logging in this module:

  • total_bytes_billed
  • total_bytes_processed

This is based on an original PR by MrwanBaghdad.

Fixes #1623 🦕

@chalmerlowe chalmerlowe requested review from a team and mrfaizal April 8, 2024 12:36
@product-auto-label product-auto-label Bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/python-bigquery API. labels Apr 8, 2024
@chalmerlowe chalmerlowe requested a review from Linchin April 8, 2024 13:01
@chalmerlowe chalmerlowe mentioned this pull request Apr 8, 2024
Closed
4 tasks
Linchin
Linchin reviewed Apr 8, 2024
View reviewed changes
Comment thread google/cloud/bigquery/opentelemetry_tracing.py
@Linchin Linchin self-assigned this Apr 10, 2024
Linchin
Linchin approved these changes Apr 11, 2024
View reviewed changes

@Linchin Linchin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Linchin Linchin merged commit 38697fb into main Apr 11, 2024
@Linchin Linchin deleted the feat-adds-billing branch April 11, 2024 17:49
@release-please release-please Bot mentioned this pull request Apr 10, 2024
Merged
This was referenced Apr 23, 2024
Closed
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@mrfaizal mrfaizal Awaiting requested review from mrfaizal
1 more reviewer
@Linchin Linchin Linchin approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@Linchin Linchin

Labels

api: bigquery Issues related to the googleapis/python-bigquery API. size: s Pull request size is small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Extend the OTEL traces to track bytes billed and bytes processed

2 participants

@chalmerlowe @Linchin
Morty Proxy This is a proxified and sanitized view of the page, visit original site.