Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings
This repository was archived by the owner on Mar 6, 2026. It is now read-only.

chore: standardize samples directory#1727

Merged
kiraksi merged 4 commits into
googleapis:maingoogleapis/python-bigquery:mainfrom
kiraksi:standardize-samples-directorykiraksi/python-bigquery:standardize-samples-directoryCopy head branch name to clipboard
Nov 17, 2023
Merged

chore: standardize samples directory#1727
kiraksi merged 4 commits into
googleapis:maingoogleapis/python-bigquery:mainfrom
kiraksi:standardize-samples-directorykiraksi/python-bigquery:standardize-samples-directoryCopy head branch name to clipboard

Conversation

@kiraksi

@kiraksi kiraksi commented Nov 16, 2023

Copy link
Copy Markdown
Contributor

This PR:

  • Copies samples that require extra dependencies other than google-cloud-bigquery to their own samples folder
  • There will be a following PR to delete the samples from the snippets folder after updating documentation

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #790 🦕

@product-auto-label product-auto-label Bot added size: l Pull request size is large. api: bigquery Issues related to the googleapis/python-bigquery API. samples Issues that are directly related to samples. labels Nov 16, 2023
@kiraksi kiraksi changed the title Standardize samples directory chore: standardize samples directory Nov 16, 2023
@product-auto-label product-auto-label Bot added size: xl Pull request size is extra large. and removed size: l Pull request size is large. labels Nov 16, 2023
@kiraksi kiraksi requested a review from tswast November 16, 2023 23:06
@kiraksi kiraksi marked this pull request as ready for review November 16, 2023 23:10
@kiraksi kiraksi requested a review from a team November 16, 2023 23:10
@kiraksi kiraksi requested a review from a team as a code owner November 16, 2023 23:10
@kiraksi kiraksi requested review from a team and loferris November 16, 2023 23:10
@snippet-bot

snippet-bot Bot commented Nov 16, 2023 •
edited
Loading

Copy link
Copy Markdown

Here is the summary of changes.

You are about to add 12 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@kiraksi kiraksi merged commit f804d63 into googleapis:main Nov 17, 2023
@kiraksi kiraksi deleted the standardize-samples-directory branch November 17, 2023 00:16
@kiraksi kiraksi mentioned this pull request Nov 17, 2023
Merged
4 tasks
kiraksi added a commit to kiraksi/python-bigquery that referenced this pull request Nov 20, 2023
@kiraksi
chore: standardize samples directory (googleapis#1727)
705741e 
* Removed all dependencies from samples/snippets thats not google-cloud-bigquery

* chore: standardizing extra-dependency samples

* readded original dependencies to sample/snippets requirements
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@loferris loferris Awaiting requested review from loferris loferris is a code owner automatically assigned from googleapis/python-samples-owners
1 more reviewer
@tswast tswast tswast approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigquery Issues related to the googleapis/python-bigquery API. samples Issues that are directly related to samples. size: xl Pull request size is extra large.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

standardize samples directory layout

2 participants

@kiraksi @tswast
Morty Proxy This is a proxified and sanitized view of the page, visit original site.